From patchwork Thu Sep 22 14:25:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12985334 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2A52C6FA82 for ; Thu, 22 Sep 2022 14:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=udAkKN0/Z9SLgjC4hdtiQCjzGXYkHM+FPkAeeYitwGE=; b=VFbaNDFl+Dno5J ZhG56vxSxKvT4Cq2CLqMvALVTHJBLk0w40LXcqdzx9ZnVswjDivjAT/hcteixvtVQoeZd4es2BzX+ U0yQ7BHNFh6yKeGURzA4G7lb1oTRR0C7Zu8ShCnDoOJof8UTtKvTaae3gC/s6G8ajuCYCn9zz/Dsa Q9KiXTE2KWz5yBcHOwoXPz20c/2InCRgvwC52RDCMZthFr6Tm7iw1OhH7uxkYxybiFtvj96PP41mH 8t6E/9+UqrNrszUu+33KaMLUlYW65ymK21EGKMBtc19yVWpfruudmUzoKC5DYeT54UylH3xZ04rdp zAeM6+ASNhqwDIFljyUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNNT-00G78T-3w; Thu, 22 Sep 2022 14:40:36 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNAn-00G10A-AX for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 14:27:33 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id C17B02B05B28; Thu, 22 Sep 2022 10:27:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 22 Sep 2022 10:27:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663856845; x= 1663864045; bh=xSm1H/SvLOO84UTCPZaxyASkQdYRdGizK9EhDQqVUIE=; b=f 7nQe8WpUbPbNHBxZyNsg4pvSmHXiHjCjDwBQfCbCldC2ndc6an6c+8+Hzh2JI7Yk l4FTAlNgzoq2PY0y6hORuVzojPbJH+dBVlC0OCc6fTuBUofhd1XabwKOisKL6kDg xvbcoJgwrPbtEcgWkuYbkRH8fz/rcSBNqNm2ZQIyzjqwp/RFNS4EGsdxNNUYw6Li O+FFH24AQeebjKV2/GZKm/Xu+OqOBUroRpp/Lca6CIFvDk24OPUqlVjyWkGg6oE1 sc5Nwld+5wnjOvhgahCrgipInV3ltbx0sdj095yQQuT75TVHyavqkqOXi5nsn3ai w6c8l1KThDV6H4da2jy1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663856845; x= 1663864045; bh=xSm1H/SvLOO84UTCPZaxyASkQdYRdGizK9EhDQqVUIE=; b=L KE0hx6dOosf71MT1/AFhqd2FZNyhM7GcIOL+JGmgJiuqRQwruhfh/IuDEzyHdWFW U0oFdscqLRXqpbWEqaVm504KW/oYl5qVAGuWUi4mHtugfFQrlYFLKaqpRZbGAcoh tJrVDryw7Tq+e/KFjj+pJHXxAxbWOtzhRnlRuEx1ECtDb15wqnbUiocy+tuF1kJ+ bm0+ArCKAxIvvVXL/6BrNGJzqHx8iE7oU38m0yrYbRjYnvwcj0Ydkv5H8eCkiREh X7rM/ZLRQfIejPphdBaAN0ve7Bgq8+PQYC/itosMvjSTQgv1ZRxi6lsrWSTySYGu po/eujcsWZe1Yqd6hNdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 10:27:23 -0400 (EDT) From: Maxime Ripard Date: Thu, 22 Sep 2022 16:25:33 +0200 Subject: [PATCH v2 16/33] drm/modes: Bail out of named mode parsing early if it's a number MIME-Version: 1.0 Message-Id: <20220728-rpi-analog-tv-properties-v2-16-f733a0ed9f90@cerno.tech> References: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> To: Jernej Skrabec , Rodrigo Vivi , Ben Skeggs , David Airlie , Maxime Ripard , Joonas Lahtinen , Emma Anholt , Karol Herbst , Samuel Holland , Jani Nikula , Thomas Zimmermann , Daniel Vetter , Lyude Paul , Maarten Lankhorst , Tvrtko Ursulin , Chen-Yu Tsai Cc: =?unknown-8bit?q?Hans_de_Goede_=3Chdegoede=40redhat=2Ecom=3E=2C_nouveau?= =?unknown-8bit?q?=40lists=2Efreedesktop=2Eorg=2C_Geert_Uytterhoeven_=3Cgeer?= =?unknown-8bit?q?t=40linux-m68k=2Eorg=3E=2C?= =?unknown-8bit?q?_Dave_Stevenson_=3Cdave=2Estevenson=40raspberrypi=2Ecom=3E?= =?unknown-8bit?q?=2C_linux-kernel=40vger=2Ekernel=2Eorg=2C_linux-arm-kernel?= =?unknown-8bit?q?=40lists=2Einfradead=2Eorg=2C?= =?unknown-8bit?q?_Phil_Elwell_=3Cphil=40raspberrypi=2Ecom=3E=2C_intel-gfx=40?= =?unknown-8bit?q?lists=2Efreedesktop=2Eorg=2C_Noralf_Tr=C3=B8nnes_=3Cnoralf?= =?unknown-8bit?q?=40tronnes=2Eorg=3E=2C?= =?unknown-8bit?q?_Dom_Cobley_=3Cdom=40raspberrypi=2Ecom=3E=2C_linux-sunxi=40?= =?unknown-8bit?q?lists=2Elinux=2Edev=2C_Maxime_Ripard_=3Cmaxime=40cerno=2Et?= =?unknown-8bit?q?ech=3E=2C?= =?unknown-8bit?q?_Mateusz_Kwiatkowski_=3Ckfyatek+publicgit=40gmail=2Ecom=3E?= =?unknown-8bit?q?=2C_dri-devel=40lists=2Efreedesktop=2Eorg?= X-Mailer: b4 0.10.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=781; i=maxime@cerno.tech; h=from:subject:message-id; bh=shGH9ck7c+L41qD2WH9TMF8BbPwoWC/90AbR/JV60RA=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMk6BQGFs9Nu79OYOVE4ojXPs7nd9zlbaO6p+tCY2StWbXlx 8GldRykLgxgXg6yYIkuMsPmSuFOzXney8c2DmcPKBDKEgYtTACZSvZ/hn6HFxvfrjBIl1jK2H3B+5a DbGrfj0aYefr7rurp/g03Xf2b4w5nxeKvCDm3bc2mnbvuUMjUWnIjVuSV4r6vF9K3BkwtH+QE= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_072729_453255_151D8DE3 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the name we want to parse starts with a digit, it's not a named mode. Thus, there's no need to compare it to the list of all the named modes we support, we can return straight away. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 8d629fbb1047..ede5b094da4c 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -2238,6 +2238,10 @@ static int drm_mode_parse_cmdline_named_mode(const char *name, if (!name_end) return 0; + /* If the name starts with a digit, it's not a named mode */ + if (isdigit(name[0])) + return 0; + /* * We're sure we're a named mode at that point, iterate over the * list of modes we're aware of.