From patchwork Mon Aug 29 13:11:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12957936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3E0BECAAD2 for ; Mon, 29 Aug 2022 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qbAMcUkdqVjjmnIFWmTF6IgLzrbJe+eKrAKFrrs6Rdo=; b=YK4evMgUqk4HDO rz4pl2+o7LQ5axFXd8KR4bpTHpDgf/yLVw6Dgkg4QNeB70onwFhVg+rd4YHsTPuwZklHV/EFpYYWd OQpC7BewezZdivRZpiEMxNxQfrIVqj5lHPFKYhdII0kRcbCDM3bpJ77/qKhf0iTjK5sTYrdQWnk2I 9WaVTBk5Mk6En+GVq3XbnpjGy+BcJPRiJp5PYWY204y6BazGsjnoAL2PAuuPURSq7F5oKdHHKWI/W 0DnRC2qy9W8rnaQp1sgaDExWNX+fhyWkZdhbnn8r5Vb1pjOm6xwu2iSv38M0dylJxv/548RILOy29 W0ZESBX8XJJSj3tw8GGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSev5-00AlTZ-1K; Mon, 29 Aug 2022 13:35:15 +0000 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSebE-00Aawz-Me for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 13:14:46 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 1EB102B0606F; Mon, 29 Aug 2022 09:14:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 29 Aug 2022 09:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661778880; x= 1661786080; bh=j2xVn9DQqZPAbk7DRoXYb3Gc5hDkTHCbiLk8VjWo/kk=; b=e W3j3X3F1dNP+pa/mcTJLoDMJqZBef4D/FGT1sPX4/CUeEpPKponvnnrEfXDmFBgW 0Nub1MuB1jlLAg/EzhjXasY8BJUQ8rKpHIhcMKQh61X8TJfZsAxPI/jJnpc24i90 amfoHYudd41jeY0PkAw7Jp/Fcu79hBGKQIp4/5g8zG3whwSC2XXJxiqJUBJamYBs /SqSk4izVhzmg7fSYZdJkXJf8tSmPWUhoa6V49XHefL01GJA2dx5AR2S1A6oV3Gc FncuE4NhSo/1roMVoYOH1bKkMMq0z+E3bkpBugIXnIl2MM3fsGVUdg9EAZcujSKu 85ZZzfRCjIjbUg1WWfj6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661778880; x= 1661786080; bh=j2xVn9DQqZPAbk7DRoXYb3Gc5hDkTHCbiLk8VjWo/kk=; b=R HBNrPu/uPbhJTXjGYBfVwYJnJN3W4TTcnoJ3vA0o7bJq86e2MA+10nN6ul7AbD37 jVqeMevFjyloNkTLwRwQpNle6qq0HueW3Z1b3XTkmD61LWaWJIGRvOdgm32a/Xd0 TkifOGVrVAi9wCnTHlUdfeOcaXKQK6sRrTS5QreBHaSKp5KJhuCn6xAV85d66/Ow MW+sGOR0ogvbG9B94FjPdrFgp+P0q983icXxiPxEy0oJ4Vlp1DyHC6OVHN8onIHY UvZRZMbKEb/ELFDqnDG2OWte0uSu+63ry4ZDBYgcC7acx7bPmVZHu2+7S71OPgQl R7KxYA08ud/pbOMvcV8Cw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekuddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfogfesthhqredtredtjeenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeefiedvfefggffgffehveejieffuddtgffhjefggeetieduvdeileet lefgveegtdenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 09:14:39 -0400 (EDT) From: Maxime Ripard To: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen Cc: Maxime Ripard , Hans de Goede , linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Dave Stevenson , dri-devel@lists.freedesktop.org, Dom Cobley , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Geert Uytterhoeven Subject: [PATCH v2 24/41] drm/vc4: vec: Remove empty mode_fixup Date: Mon, 29 Aug 2022 15:11:38 +0200 Message-Id: <20220728-rpi-analog-tv-properties-v2-24-459522d653a7@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> MIME-Version: 1.0 X-Mailer: b4 0.10.0-dev-65ba7 X-Developer-Signature: v=1; a=openpgp-sha256; l=1269; i=maxime@cerno.tech; h=from:subject:message-id; bh=wQYMsg2bmhLsKtW1lnmR3k72TWcOcF4pQQLI7ZjpLm0=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMk8uxQqthccT5d7kl7cGP7Z2vzITQYBtV97u7dd+v/Ya6bS jAb2jlIWBjEuBlkxRZYYYfMlcadmve5k45sHM4eVCWQIAxenAEzkqQ4jw9L3sqcktpqIlbzZcln/k6 C34ko95pNZC9sU98xq3jih5SwjQ5dQc8fjcOFz9xle79zLrRrpuTpw68Zld2Q5+rb8bPfN4QUA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_061444_826221_B6DA231D X-CRM114-Status: UNSURE ( 7.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The mode_fixup hooks are deprecated, and the behaviour we implement is the default one anyway. Let's remove it. Signed-off-by: Maxime Ripard Reviewed-by: Noralf Trønnes diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c index d5140fe0be4f..d521ffd8d75c 100644 --- a/drivers/gpu/drm/vc4/vc4_vec.c +++ b/drivers/gpu/drm/vc4/vc4_vec.c @@ -483,14 +483,6 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder) drm_dev_exit(idx); } - -static bool vc4_vec_encoder_mode_fixup(struct drm_encoder *encoder, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - return true; -} - static void vc4_vec_encoder_atomic_mode_set(struct drm_encoder *encoder, struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) @@ -518,7 +510,6 @@ static int vc4_vec_encoder_atomic_check(struct drm_encoder *encoder, static const struct drm_encoder_helper_funcs vc4_vec_encoder_helper_funcs = { .disable = vc4_vec_encoder_disable, .enable = vc4_vec_encoder_enable, - .mode_fixup = vc4_vec_encoder_mode_fixup, .atomic_check = vc4_vec_encoder_atomic_check, .atomic_mode_set = vc4_vec_encoder_atomic_mode_set, };