Message ID | 20220801030509.21966-3-samuel@sholland.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | soc: sunxi: sram: Fixes and D1 support | expand |
Dne ponedeljek, 01. avgust 2022 ob 05:05:02 CEST je Samuel Holland napisal(a): > sunxi_sram_claim() checks the sram_desc->claimed flag before updating > the register, with the intent that only one device can claim a region. > However, this was ineffective because the flag was never set. > > Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map > SRAMs") Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index a8f3876963a0..f3d3f9259df9 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -254,6 +254,7 @@ int sunxi_sram_claim(struct device *dev) writel(val | ((device << sram_data->offset) & mask), base + sram_data->reg); + sram_desc->claimed = true; spin_unlock(&sram_lock); return 0;
sunxi_sram_claim() checks the sram_desc->claimed flag before updating the register, with the intent that only one device can claim a region. However, this was ineffective because the flag was never set. Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs") Signed-off-by: Samuel Holland <samuel@sholland.org> --- drivers/soc/sunxi/sunxi_sram.c | 1 + 1 file changed, 1 insertion(+)