From patchwork Fri Aug 5 21:53:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 12937724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5D75C25B0C for ; Fri, 5 Aug 2022 21:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mm0sqvlV5Aen1jpxfwiauaH6QIAHR9njQCQDyJMuPgc=; b=JW4Cz6YlQI/URA nYwhOe36BiuL/5djx4QntHQjNm1bjdvgfYGebtfBnqHuAQPp4RIetzUpwTS2PwMsEXvUJV9/NCvWn 9FicwhuCZNFwAG4bmwkZcq23SmfZ1e3r/8KW6QvUNYlh0Y+bpX8YlxxlKKqqPGLBCq9Ou0pkhTDly eXIBte49SM3sKiDMwRIPtcWcnXaoPD/Kzk7kQAobzQ0vppdVfGitxORvDXHd+XhGrX5UdgI4jKoc+ tr/PkPOB0b3fxSILbsPM1sKyGEBmBXp7KSKhc2usdP3TurJyofCMnE2lCfukvlBRzGoQ14qZ19nKE eTue6Us3DUnG5CjRd3hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oK5Hd-000yUu-TG; Fri, 05 Aug 2022 21:55:06 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oK5Gt-000xzD-3i for linux-arm-kernel@lists.infradead.org; Fri, 05 Aug 2022 21:54:20 +0000 Received: by mail-il1-x12b.google.com with SMTP id t15so1972942ilm.7 for ; Fri, 05 Aug 2022 14:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=66tB9GURiJGDaXzm2IfI1R+C6P9N6jM87DtEYp8w9s8=; b=dgd+LLVPNiPJaSKBVWtT4Zbrhte0+5f0xGVwua9lB+amp0r06ne081BVPeuysGQfVy B29SsUeBngUq34NP88kyqho6gSyjz34xlIC/USckZDng+OQZv8goMxRKQA03ABRzcBd0 aAZ+CBBWePvCN3kUwH4EYfOSISYXjUPP8ZXfH0oPGfcMexyLS6Vxz16Fch/fYRc43CcD h6G6O8nkZbmHpzetqnntDg5Zib/pD4u+1z3iJ8z6TOATqewv5E6xnluDu/IaExNjLqWm 0D3Jd0LJlJOcVmbDYGtHyerwGVhcxoMT874pS287WwzN3ne6cWGax4fucNDz+Iei8SEj /sMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=66tB9GURiJGDaXzm2IfI1R+C6P9N6jM87DtEYp8w9s8=; b=OV9wisYUuqPbDF97jB6xUgqF6K6UUoFoYUR+XnyWHfdHWc/KLPdz4nEYiVAGQGKcwU rLraHVat3vPkUBxOM2yuXhfTnz2QjbzIqSMVOsdQVt1pCUKNe0rV9/lGQVG5teodEieg iDtEQbigfCd9ti4QDqlq7pMoKaSdwRNt2XO4fkwjwUO4gVXX0yhaGWGbmy1KnJNqPbmg QNHN2HA9oobStL9hYIW9VQVlRfa5mf1VP94+TRp7++t/Gxcwy0Tr6re6GMdOQqWImfCe zd06LbGSgtKfu1q8kW7hWZuLyD1iFEbXVKB6wPuK7knZ/A6x8qhOZxbPklSYFJblMBwd w/zQ== X-Gm-Message-State: ACgBeo3FUIn8gVZll3/Foxrx9ui87uw7yJkr0hKprsYZ9dkYy0teaBDa xZfsSyCRtLndwxBaant2W6I= X-Google-Smtp-Source: AA6agR5KFUx/S28wJBHf8esIf0A1i4foONGppbKZtYzDKa5yseZsXVQGDnoxzq0dnljYp9wy7F7U6A== X-Received: by 2002:a92:d606:0:b0:2dc:e2d1:b75b with SMTP id w6-20020a92d606000000b002dce2d1b75bmr4023671ilm.91.1659736458782; Fri, 05 Aug 2022 14:54:18 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e12-20020a056602044c00b0067c09fd0b53sm1765532iov.21.2022.08.05.14.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 14:54:18 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie Subject: [PATCH v5 03/33] dyndbg: show both old and new in change-info Date: Fri, 5 Aug 2022 15:53:25 -0600 Message-Id: <20220805215355.3509287-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220805215355.3509287-1-jim.cromie@gmail.com> References: <20220805215355.3509287-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220805_145419_275512_4DF7708F X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org print "old => new" flag values to the info("change") message. no functional change. Signed-off-by: Jim Cromie Acked-by: Jason Baron --- lib/dynamic_debug.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a56c1286ffa4..8faf584f2f4b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -156,7 +156,7 @@ static int ddebug_change(const struct ddebug_query *query, struct ddebug_table *dt; unsigned int newflags; unsigned int nfound = 0; - struct flagsbuf fbuf; + struct flagsbuf fbuf, nbuf; /* search for matching ddebugs */ mutex_lock(&ddebug_lock); @@ -217,11 +217,12 @@ static int ddebug_change(const struct ddebug_query *query, static_branch_enable(&dp->key.dd_key_true); } #endif + v4pr_info("changed %s:%d [%s]%s %s => %s\n", + trim_prefix(dp->filename), dp->lineno, + dt->mod_name, dp->function, + ddebug_describe_flags(dp->flags, &fbuf), + ddebug_describe_flags(newflags, &nbuf)); dp->flags = newflags; - v4pr_info("changed %s:%d [%s]%s =%s\n", - trim_prefix(dp->filename), dp->lineno, - dt->mod_name, dp->function, - ddebug_describe_flags(dp->flags, &fbuf)); } } mutex_unlock(&ddebug_lock);