| Message ID | 20220812043424.4078034-2-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i2c-imx-lpi2c: add IPG clock | expand |
On 12/08/2022 07:34, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX LPI2C actually requires dual clock: per clock and ipg clock, so add > both. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 9 ++++++--- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 12 Aug 2022 12:34:19 +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX LPI2C actually requires dual clock: per clock and ipg clock, so add > both. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ i2c@40a40000: clock-names:0: 'per' was expected arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a40000: clock-names: ['ipg'] is too short arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a40000: clocks: [[14, 2]] is too short arch/arm/boot/dts/imx7ulp-com.dtb i2c@40a40000: clocks: [[18, 2]] is too short arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a40000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a50000: clock-names:0: 'per' was expected arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a50000: clock-names: ['ipg'] is too short arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a50000: clocks: [[14, 3]] is too short arch/arm/boot/dts/imx7ulp-com.dtb i2c@40a50000: clocks: [[18, 3]] is too short arch/arm/boot/dts/imx7ulp-evk.dtb i2c@40a50000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm/boot/dts/imx7ulp-com.dtb arch/arm/boot/dts/imx7ulp-evk.dtb i2c@5a800000: clock-names: ['per'] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a800000: clocks: [[15, 0]] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb i2c@5a800000: clocks: [[35, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb i2c@5a800000: clocks: [[37, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a800000: clocks: [[38, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb i2c@5a800000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a810000: clock-names: ['per'] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a810000: clocks: [[16, 0]] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb i2c@5a810000: clocks: [[36, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb i2c@5a810000: clocks: [[38, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a810000: clocks: [[43, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb i2c@5a810000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a820000: clock-names: ['per'] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a820000: clocks: [[17, 0]] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb i2c@5a820000: clocks: [[37, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb i2c@5a820000: clocks: [[43, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a820000: clocks: [[45, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb i2c@5a820000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a830000: clock-names: ['per'] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a830000: clocks: [[18, 0]] is too short arch/arm64/boot/dts/freescale/imx8qm-mek.dtb i2c@5a830000: clocks: [[38, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb i2c@5a830000: clocks: [[44, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb i2c@5a830000: clocks: [[46, 0]] is too short arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb i2c@5a830000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml index 529bea56d324..e42e35003eae 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml @@ -37,10 +37,12 @@ properties: clock-frequency: true clock-names: - maxItems: 1 + items: + - const: per + - const: ipg clocks: - maxItems: 1 + maxItems: 2 power-domains: maxItems: 1 @@ -63,5 +65,6 @@ examples: reg = <0x40A50000 0x10000>; interrupt-parent = <&intc>; interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX7ULP_CLK_LPI2C7>; + clocks = <&clks IMX7ULP_CLK_LPI2C7>, + <&clks IMX7ULP_CLK_NIC1_BUS_DIV>; };