| Message ID | 20220812173526.15537-1-tharvey@gateworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity | expand |
Hi Tim, On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote: > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > index 521215520a0f..de17021df53f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_reg_can>; > regulator-name = "can2_stby"; > - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>; > - enable-active-high; > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>; > + enable-active-low; This 'enable-active-low' property does not exist. Just remove it.
On Fri, Aug 12, 2022 at 10:51 AM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Tim, > > On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > index 521215520a0f..de17021df53f 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_reg_can>; > > regulator-name = "can2_stby"; > > - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>; > > - enable-active-high; > > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>; > > + enable-active-low; > > This 'enable-active-low' property does not exist. Just remove it. Fabio, Thanks - I see now that for active-low you just omit the 'enable-active-high' prop. I will send a new version. Thanks, Tim
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index 521215520a0f..de17021df53f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_reg_can>; regulator-name = "can2_stby"; - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>; + enable-active-low; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; };
The CAN STBY poarlity is active-low. Specify it as such. Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support") Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)