From patchwork Mon Aug 15 04:12:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 12943096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22A98C00140 for ; Mon, 15 Aug 2022 04:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+i+zUHpJvTMY4feKEPcMP8wIAG+KHGlTXMtdgelzJeE=; b=W11RFtHwDXTarm P4xK32Qp2SjNFL53LHLfgV6vFK4lQawN31Qg2BugMSHFSQZbdnXABJ3CljIoW+wtb4tsRFY5t8U07 F6IEhKFojhUvB/FF9uyYEuoPY1vPbWNIgwm2xtccIBnbhhoGi9Wx/YAQ96RgEYuM9WmnicbML+MpA QlvikAh4u66jdYnzf8pJmiNv3dfVgfLEtVAImE6BL8OAL8ntFXG2eXlDQbJuU8MlOHMPztCusbnRN 0T8KJHvkowDrx1jJ3O7TiQqaoUOc1OgaFfAhOl9b8i1pyxhodoBdJHI7q4t220ei60TTos9nEPSgd d5OfMjHuNLaBDAT/HFdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNRTm-00B56l-Ev; Mon, 15 Aug 2022 04:13:30 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNRTL-00B4ua-2R for linux-arm-kernel@lists.infradead.org; Mon, 15 Aug 2022 04:13:05 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 69E2232003CE; Mon, 15 Aug 2022 00:13:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 00:13:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660536780; x=1660623180; bh=Um nIFzo9e00XsWhF+6vCJvzdXF32upMbbbcab6Vz/QM=; b=QBFbrqBFOIOpH8O5w3 FqfbCxvmLZBFw1F9jY1eoEHTJguMAv8M7MY6ZLj8rNG3+c7iVOOR7rQn1pfEmSF6 ykWOZJdUzJawKQznQFOWBGeddSXgOIFmwCMdU92OoQiY15i/mqFF6AjdsjEz4Hlr 8ppUbc8YRS3IyR3kP0nC8qMkfo4qDqQLfofMcSqFHW4p83SLbwGjtCkaWNJ+QRKb Jcm2U95hFyhJRM2H+wyyqqEYaQDs/i0Af5XMO5iXLMeHI+MWgxGvy5Dx+ufNb2dl UVuwSeq1qkAZDVA3q80/PxZCnvGzL+7KJeCRkP8vN4UdaRaZo9hZqJtqrbDf4I29 ZlfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660536780; x=1660623180; bh=UmnIFzo9e00Xs WhF+6vCJvzdXF32upMbbbcab6Vz/QM=; b=NGBLS/HxWkE/vdZ9fOtJNHwab6TLH 4lfw9b/gQv2CtMwkaVqVsrG8300OSFYmmZ8ba6lmLNbjDy/na2xXrrF8zhAluZC8 DfjKa8Cx6+Z6qLfXIztkX1CKh/H1haO/OnuNUqOMcH1CiUUTORKYIkl4/NFcI8US lsMO+0bh6+bHlHKyacpCt2bCZEYaiOTWltMvpr7FCXbsMKHO5XJa7soqBQ4sthv+ a0P0LnNxHioKr2JrwYq6jPvSHocnisNkYaAQk6duEJ9+d22VkFtfW6QbK+9AMsxw bKMaHlTEdlXUezR9pj86nZP2QrnyyBkaW8k1bGs6tGq8HjKZqjvUPR7tQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg udefiedtveetnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 00:13:00 -0400 (EDT) From: Samuel Holland To: Chen-Yu Tsai , Jernej Skrabec Cc: Samuel Holland , Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH v2 03/10] soc: sunxi: sram: Actually claim SRAM regions Date: Sun, 14 Aug 2022 23:12:40 -0500 Message-Id: <20220815041248.53268-4-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220815041248.53268-1-samuel@sholland.org> References: <20220815041248.53268-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220814_211304_411024_DAC3388A X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org sunxi_sram_claim() checks the sram_desc->claimed flag before updating the register, with the intent that only one device can claim a region. However, this was ineffective because the flag was never set. Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs") Reviewed-by: Jernej Skrabec Signed-off-by: Samuel Holland Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner --- (no changes since v1) drivers/soc/sunxi/sunxi_sram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index a8f3876963a0..f3d3f9259df9 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -254,6 +254,7 @@ int sunxi_sram_claim(struct device *dev) writel(val | ((device << sram_data->offset) & mask), base + sram_data->reg); + sram_desc->claimed = true; spin_unlock(&sram_lock); return 0;