| Message ID | 20220819190054.31348-3-a-nandan@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add initial support for J784s4 SoC | expand |
On Sat, 20 Aug 2022 00:30:52 +0530, Apurva Nandan wrote: > Add pinctrl macros for J784s4 SoC. These macro definitions are > similar to that of J721s2, but adding new definitions to avoid > any naming confusions in the soc dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > Signed-off-by: Apurva Nandan <a-nandan@ti.com> > --- > include/dt-bindings/pinctrl/k3.h | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Fri, Aug 19, 2022 at 9:01 PM Apurva Nandan <a-nandan@ti.com> wrote: > Add pinctrl macros for J784s4 SoC. These macro definitions are > similar to that of J721s2, but adding new definitions to avoid > any naming confusions in the soc dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > Signed-off-by: Apurva Nandan <a-nandan@ti.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> I guess you will merge these patches together? Tell me if you rather want that I apply this one patch to the pinctrl tree. Yours, Linus Walleij
On 26/08/22 13:59, Linus Walleij wrote: > On Fri, Aug 19, 2022 at 9:01 PM Apurva Nandan <a-nandan@ti.com> wrote: > >> Add pinctrl macros for J784s4 SoC. These macro definitions are >> similar to that of J721s2, but adding new definitions to avoid >> any naming confusions in the soc dts files. >> >> checkpatch insists the following error exists: >> ERROR: Macros with complex values should be enclosed in parentheses >> >> However, we do not need parentheses enclosing the values for this >> macro as we do intend it to generate two separate values as has been >> done for other similar platforms. >> >> Signed-off-by: Hari Nagalla <hnagalla@ti.com> >> Signed-off-by: Apurva Nandan <a-nandan@ti.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > I guess you will merge these patches together? > Tell me if you rather want that I apply this one patch to the pinctrl tree. > I will the patch via TI K3 SoC tree once other patches are in good shape. Thanks for the review!
diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h index a5204ab91d3e..f258074fd009 100644 --- a/include/dt-bindings/pinctrl/k3.h +++ b/include/dt-bindings/pinctrl/k3.h @@ -41,6 +41,9 @@ #define J721S2_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) #define J721S2_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define J784S4_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define J784S4_WKUP_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) + #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))