| Message ID | 20220821173051.155038-4-peron.clem@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allwinner H6 GPU devfreq | expand |
On 8/21/22 12:30 PM, Clément Péron wrote: > Add an Operating Performance Points table for the GPU to > enable Dynamic Voltage & Frequency Scaling on the H6. > > The voltage range is set with minival voltage set to the target > and the maximal voltage set to 1.2V. This allow DVFS framework to > work properly on board with fixed regulator. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > new file mode 100644 > index 000000000000..a66204243515 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (C) 2022 Clément Péron <peron.clem@gmail.com> > + > +/ { > + gpu_opp_table: gpu-opp-table { > + compatible = "operating-points-v2"; > + > + opp@216000000 { Please fix the `make dtbs_check` warnings: arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dtb: gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' From schema: Documentation/devicetree/bindings/opp/opp-v2.yaml arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dtb: gpu-opp-table: Unevaluated properties are not allowed ('opp@216000000', 'opp@264000000', 'opp@312000000', 'opp@336000000', 'opp@360000000', 'opp@384000000', 'opp@408000000', 'opp@420000000', 'opp@432000000', 'opp@456000000', 'opp@504000000', 'opp@540000000', 'opp@576000000', 'opp@624000000', 'opp@756000000' were unexpected) From schema: Documentation/devicetree/bindings/opp/opp-v2.yaml Regards, Samuel
On 21/08/2022 20:30, Clément Péron wrote: > Add an Operating Performance Points table for the GPU to > enable Dynamic Voltage & Frequency Scaling on the H6. > > The voltage range is set with minival voltage set to the target > and the maximal voltage set to 1.2V. This allow DVFS framework to > work properly on board with fixed regulator. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > new file mode 100644 > index 000000000000..a66204243515 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (C) 2022 Clément Péron <peron.clem@gmail.com> > + > +/ { > + gpu_opp_table: gpu-opp-table { I don't think you tested the change with dtbs_check. This does not match the bindings. > + compatible = "operating-points-v2"; > + > + opp@216000000 { > + opp-hz = /bits/ 64 <216000000>; > + opp-microvolt = <810000 810000 1200000>; > + }; > + > + opp@264000000 { > + opp-hz = /bits/ 64 <264000000>; > + opp-microvolt = <810000 810000 1200000>; > + }; > + > + opp@312000000 { > + opp-hz = /bits/ 64 <312000000>; > + opp-microvolt = <810000 810000 1200000>; > + }; > + > + opp@336000000 { > + opp-hz = /bits/ 64 <336000000>; > + opp-microvolt = <810000 810000 1200000>; > + }; > + > + opp@360000000 { > + opp-hz = /bits/ 64 <360000000>; > + opp-microvolt = <820000 820000 1200000>; > + }; > + > + opp@384000000 { > + opp-hz = /bits/ 64 <384000000>; > + opp-microvolt = <830000 830000 1200000>; > + }; > + > + opp@408000000 { > + opp-hz = /bits/ 64 <408000000>; > + opp-microvolt = <840000 840000 1200000>; > + }; > + > + opp@420000000 { > + opp-hz = /bits/ 64 <420000000>; > + opp-microvolt = <850000 850000 1200000>; > + }; > + > + opp@432000000 { > + opp-hz = /bits/ 64 <432000000>; > + opp-microvolt = <860000 860000 1200000>; > + }; > + > + opp@456000000 { > + opp-hz = /bits/ 64 <456000000>; > + opp-microvolt = <870000 870000 1200000>; > + }; > + > + opp@504000000 { > + opp-hz = /bits/ 64 <504000000>; > + opp-microvolt = <890000 890000 1200000>; > + }; > + > + opp@540000000 { > + opp-hz = /bits/ 64 <540000000>; > + opp-microvolt = <910000 910000 1200000>; > + }; > + > + opp@576000000 { > + opp-hz = /bits/ 64 <576000000>; > + opp-microvolt = <930000 930000 1200000>; > + }; > + > + opp@624000000 { > + opp-hz = /bits/ 64 <624000000>; > + opp-microvolt = <950000 950000 1200000>; > + }; > + > + opp@756000000 { > + opp-hz = /bits/ 64 <756000000>; > + opp-microvolt = <1040000 1040000 1200000>; > + }; > + }; > + No need for such blank lines. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode 100644 index 000000000000..a66204243515 --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi @@ -0,0 +1,88 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2022 Clément Péron <peron.clem@gmail.com> + +/ { + gpu_opp_table: gpu-opp-table { + compatible = "operating-points-v2"; + + opp@216000000 { + opp-hz = /bits/ 64 <216000000>; + opp-microvolt = <810000 810000 1200000>; + }; + + opp@264000000 { + opp-hz = /bits/ 64 <264000000>; + opp-microvolt = <810000 810000 1200000>; + }; + + opp@312000000 { + opp-hz = /bits/ 64 <312000000>; + opp-microvolt = <810000 810000 1200000>; + }; + + opp@336000000 { + opp-hz = /bits/ 64 <336000000>; + opp-microvolt = <810000 810000 1200000>; + }; + + opp@360000000 { + opp-hz = /bits/ 64 <360000000>; + opp-microvolt = <820000 820000 1200000>; + }; + + opp@384000000 { + opp-hz = /bits/ 64 <384000000>; + opp-microvolt = <830000 830000 1200000>; + }; + + opp@408000000 { + opp-hz = /bits/ 64 <408000000>; + opp-microvolt = <840000 840000 1200000>; + }; + + opp@420000000 { + opp-hz = /bits/ 64 <420000000>; + opp-microvolt = <850000 850000 1200000>; + }; + + opp@432000000 { + opp-hz = /bits/ 64 <432000000>; + opp-microvolt = <860000 860000 1200000>; + }; + + opp@456000000 { + opp-hz = /bits/ 64 <456000000>; + opp-microvolt = <870000 870000 1200000>; + }; + + opp@504000000 { + opp-hz = /bits/ 64 <504000000>; + opp-microvolt = <890000 890000 1200000>; + }; + + opp@540000000 { + opp-hz = /bits/ 64 <540000000>; + opp-microvolt = <910000 910000 1200000>; + }; + + opp@576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-microvolt = <930000 930000 1200000>; + }; + + opp@624000000 { + opp-hz = /bits/ 64 <624000000>; + opp-microvolt = <950000 950000 1200000>; + }; + + opp@756000000 { + opp-hz = /bits/ 64 <756000000>; + opp-microvolt = <1040000 1040000 1200000>; + }; + }; + +}; + +&gpu { + operating-points-v2 = <&gpu_opp_table>; +};
Add an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6. The voltage range is set with minival voltage set to the target and the maximal voltage set to 1.2V. This allow DVFS framework to work properly on board with fixed regulator. Signed-off-by: Clément Péron <peron.clem@gmail.com> --- .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi