diff mbox series

[1/2] dt-bindings: arm: rockchip: Document Radxa ROCK 4C+

Message ID 20220824080903.3696847-1-jagan@amarulasolutions.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: arm: rockchip: Document Radxa ROCK 4C+ | expand

Commit Message

Jagan Teki Aug. 24, 2022, 8:09 a.m. UTC
Document the dt-bindings for Radxa ROCK 4C+ SBC.

4C+ replaced DP with HDMI and updated FPC connectors
for MIPI DSI/CSI compared to 4C revision.

Also, an official naming conventionĀ from Radxa mention
to remove Pi from board name, so this 4C+ is named as
Radxa ROCK 4C+ not Radxa ROCK Pi 4C+.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Aug. 24, 2022, 12:42 p.m. UTC | #1
On 24/08/2022 11:09, Jagan Teki wrote:
> Document the dt-bindings for Radxa ROCK 4C+ SBC.
> 
> 4C+ replaced DP with HDMI and updated FPC connectors
> for MIPI DSI/CSI compared to 4C revision.
> 
> Also, an official naming conventionĀ from Radxa mention
> to remove Pi from board name, so this 4C+ is named as
> Radxa ROCK 4C+ not Radxa ROCK Pi 4C+.

This does not look like wrapped according to Linux style.

https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

With wrapping fixes:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 7811ba64149c..ec3525fb1e60 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -537,6 +537,11 @@  properties:
           - const: radxa,rockpi4
           - const: rockchip,rk3399
 
+      - description: Radxa ROCK 4C+
+        items:
+          - const: radxa,rock-4c-plus
+          - const: rockchip,rk3399
+
       - description: Radxa ROCK Pi E
         items:
           - const: radxa,rockpi-e