From patchwork Thu Aug 25 07:24:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinpu Wang X-Patchwork-Id: 12954289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D950C28D13 for ; Thu, 25 Aug 2022 07:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ikuiKT+NzOa0w3X80oht2CtntdDTI3UkGjRTwAPkusA=; b=4BhiUbJGHb9+ay wJFfkcShKDwGgrp3qPX5MRWNQzdvqJdx5STv6KLDEMhdI8FoU9htLmho18VsxW0EWaMhQogmkYTTO ZzwyErfIhXNHkP89elHpBzW5MHDzTc6HTCBQMcEXyYbFFJWLfS1XIpTShWFdcbkY3RCdI1jV0m+gs QJrq6U8Y0VoxHUlBJj+aoPpY/ceCZ7GOdFuLTWLW5AFZPr44uAZao2Gce4u4YM9nw+y05O+wo5xp3 85TRr6VXCKpGXg46J8ol7FsR8mNv0vfEa9NwikJrdBlpF+vvAEj/IYkwViiAWviwtVFRcqp1qI0oF rq/xfUuz+KqWNlqn/Z1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR7E7-008z0i-Tw; Thu, 25 Aug 2022 07:24:32 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR7E3-008yWy-GK for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 07:24:29 +0000 Received: by mail-ej1-x636.google.com with SMTP id d21so18468152eje.3 for ; Thu, 25 Aug 2022 00:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=4oX7Kz3MVV4hSXJmoV3BElc0F08jxmt7raiQQsmxayc=; b=MW5H/NNoqjJGKjOXPEUp6diJ0Ebk/7ve+sG3Vf+l0KuUBAvXz50GCgcJA7dHF9RJ/F YV/wOibDRkpDRz0sxjw3FI6zpSxqAJhGSdlI/poeQ1wGxShokSYfdqEa/N9SYMbHYltQ 8aS3yEcIDE5WMl1gLsBxto2pvSbrnNxlrdczPsANNjjd0el6V17a15Kru2mtpPeAaIlq jkSt7scusL3g90qGNjr6AVdm+8+0TO+xzAz7a31PiMrRRq1SJ6r3Nez1lVaKTFkFn4uC eCrb+CCZFAk7kAOIu8uO3XWZecG+oZ4w8EoHj8P8lfNlPvUmj/bsNUsKsWVOA5XumtFe WGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=4oX7Kz3MVV4hSXJmoV3BElc0F08jxmt7raiQQsmxayc=; b=v6Aj2EcKyKdiabON/Xu1movTdjCDEp62YqiI1E/9M3nCOPmZPgALs6+zs0Esbdf5xW liVTwYTU6JovYQwjsmw6WPNx0DUab1aMBRr7snYa03MxCJeoPqBcXkczuaoUPBqVr3Zc X6BbY+5xIuqhdbqheXQwpuk8V6UY6I3SaXLwnfbrNtNyo1tI9neYUMP7w7NEOw6t03Yt XX8E2OeeHGqBn6KtEsbrNMKqK3hfXabIx62MaRGxX6f18f9qjAEKXIVtUPrzwChA0VbR Jj/ogoNonMTS9lXSdPYxbYLMANEfFx54gPtnZoCFcNsQ815nMhHT4tidMuUPe5iXfgsB rd7A== X-Gm-Message-State: ACgBeo3aFzcYWS06MOoLGC2uEXcnuxLLwXAIsIdzyfr/L3i2yFZ9z2ol aNCKX8bnbvMlkslx+AnEK/KUmQ== X-Google-Smtp-Source: AA6agR7lhsz5pWp2kpFfMDfBBKJfF6f8ewMsA/5Mzz4qzehyEEhDRGqQs7+PcOiIi+6aXE6zbycuUg== X-Received: by 2002:a17:907:970b:b0:73d:5a29:959 with SMTP id jg11-20020a170907970b00b0073d5a290959mr1656893ejc.183.1661412262910; Thu, 25 Aug 2022 00:24:22 -0700 (PDT) Received: from lb02065.fritz.box ([2001:9e8:142d:a900:eab:b5b1:a064:1d0d]) by smtp.gmail.com with ESMTPSA id ky12-20020a170907778c00b0073ce4abf093sm2032281ejc.214.2022.08.25.00.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 00:24:22 -0700 (PDT) From: Jack Wang To: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org Cc: Corentin Labbe , Hans Ulli Kroll , Linus Walleij , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg Date: Thu, 25 Aug 2022 09:24:16 +0200 Message-Id: <20220825072421.29020-2-jinpu.wang@ionos.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220825072421.29020-1-jinpu.wang@ionos.com> References: <20220825072421.29020-1-jinpu.wang@ionos.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_002428_488035_A36C8B24 X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dma_map_sg return 0 on error. Cc: Corentin Labbe Cc: Hans Ulli Kroll Cc: Linus Walleij Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Fixes: 46c5338db7bd ("crypto: sl3516 - Add sl3516 crypto engine") Signed-off-by: Jack Wang --- drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c index 14d0d83d388d..34fea8aa91b6 100644 --- a/drivers/crypto/gemini/sl3516-ce-cipher.c +++ b/drivers/crypto/gemini/sl3516-ce-cipher.c @@ -149,7 +149,7 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) if (areq->src == areq->dst) { nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src), DMA_BIDIRECTIONAL); - if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) { + if (!nr_sgs || nr_sgs > MAXDESC / 2) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; @@ -158,14 +158,14 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) } else { nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) { + if (!nr_sgs || nr_sgs > MAXDESC / 2) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; } nr_sgd = dma_map_sg(ce->dev, areq->dst, sg_nents(areq->dst), DMA_FROM_DEVICE); - if (nr_sgd <= 0 || nr_sgd > MAXDESC) { + if (!nr_sgd || nr_sgd > MAXDESC) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd); err = -EINVAL; goto theend_sgs;