diff mbox series

[1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'

Message ID 20220827175011.1696398-1-festevam@denx.de (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' | expand

Commit Message

Fabio Estevam Aug. 27, 2022, 5:50 p.m. UTC
The 'enable-active-low' property is not a valid one. 

Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.

Remove the invalid 'enable-active-low' property.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Blumenstingl Aug. 27, 2022, 8:34 p.m. UTC | #1
Hi Fabio,

thanks for your patch!

On Sat, Aug 27, 2022 at 7:50 PM Fabio Estevam <festevam@denx.de> wrote:
>
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Unfortunately the linux-amlogic mailing list is not in the recipient
list so I don't think that the patch can be applied like this.
Could you please re-sending it with the linux-amlogic list included
(same for patch 2/2)?


Thank you!
Martin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index b4e86196e346..b2bb94981838 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -111,7 +111,6 @@  vcc_5v: regulator-vcc_5v {
 		vin-supply = <&dc_in>;
 
 		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
-		enable-active-low;
 	};
 
 	vddao_1v8: regulator-vddao_1v8 {