diff mbox series

arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header

Message ID 20220909135150.4063471-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header | expand

Commit Message

Fabio Estevam Sept. 9, 2022, 1:51 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

imx8mm-tqma8mqml.dtsi has PCIe support, so it should include
<dt-bindings/phy/phy-imx8-pcie.h>.

Otherwise, there are build errors when this SoM dtsi is included
on customers' carrier boards.

Fixes: 1d84283101fc ("arm64: dts: tqma8mqml: add PCIe support")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Alexander Stein Sept. 9, 2022, 2:08 p.m. UTC | #1 
Hello Fabio,

thanks for the patch.

Am Freitag, 9. September 2022, 15:51:50 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
> 
> imx8mm-tqma8mqml.dtsi has PCIe support, so it should include
> <dt-bindings/phy/phy-imx8-pcie.h>.
> 
> Otherwise, there are build errors when this SoM dtsi is included
> on customers' carrier boards.
> 
> Fixes: 1d84283101fc ("arm64: dts: tqma8mqml: add PCIe support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi index
> 16ee9b5179e6..f649dfacb4b6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> @@ -3,6 +3,7 @@
>   * Copyright 2020-2021 TQ-Systems GmbH
>   */
> 
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
>  #include "imx8mm.dtsi"
> 
>  / {

Does it make sense to remove this include from the board then? It's not needed 
then anymore. Either way:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
index 16ee9b5179e6..f649dfacb4b6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
@@ -3,6 +3,7 @@ 
  * Copyright 2020-2021 TQ-Systems GmbH
  */
 
+#include <dt-bindings/phy/phy-imx8-pcie.h>
 #include "imx8mm.dtsi"
 
 / {