From patchwork Thu Sep 15 19:08:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12977706 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED186C32771 for ; Thu, 15 Sep 2022 19:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/mGsuVORmuyYU2FAktxjpo+niq616VfYhI9NvqEup8A=; b=4+tpc3HcpM/jsa cLO2fiLgnOpdBP1l165qSv4wT66maQj2djoDG+HdDeg55lQn9kvdk1feOzyKRBZh72B4iZTas96Ww 5EfBKxnMPcHgyJz0lPxCx/a+n4Cp9WikC9dAdsx/8YoR7ZttnehlkXyyG6N2YcerE5ZJXvGOscfN4 5Rg1AyJah0X/+SnhruEBcSW9kmGByMEPa4CYISNHoTqJ8mktMuL0L8Qzh0y9Ybw1O2rWBRpZiLi7+ Z1ofYj0g+laIffhJBCSZmbGfT2XlSSR0GwV6uL8YbchDUjh27EDNtaM8HkN1t0ZZyNbWjZSRyd4qr xhAhFsqc3ULoEx1+6cRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYuDr-00Fm0D-TT; Thu, 15 Sep 2022 19:08:28 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYuDo-00FlzB-H0 for linux-arm-kernel@lists.infradead.org; Thu, 15 Sep 2022 19:08:25 +0000 Received: by mail-qt1-x82e.google.com with SMTP id g12so13982525qts.1 for ; Thu, 15 Sep 2022 12:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=V+nu0Mnx9w8PWr9j2bzDveVOduNia2P/PPn8+xHhcd4=; b=TO2BE68U+tP04b1bnYfJJCXlNf4kELGPJS8LP8DPHxwVWH74k/pl5hyCfRQKjF5rBF G6cR5wTLeDrbILIUDIBs4CjZf8idHw7EmVGnmS6nTptwuF3GvsssOyew7bpSCCYLA++y 8Lc782o5GYFl206c1sdwiVVfNV2k+MEdpoPBVPjnHNnNvZyCdsOJqjQ8RMDWMeuvDLs8 na0FI9n8IhaTO1gn2YXXUIzUg3b98l26c6m79OXmRwXq8rjDZ84ks+gKQhljFhc5C1q4 VA2WEtndM8r8xUxCqVYziEBFI8JvUzDC+r4JGELTGgQU1seTkT1Jd+xXXS+2CkUyggs+ jTQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=V+nu0Mnx9w8PWr9j2bzDveVOduNia2P/PPn8+xHhcd4=; b=p9DAgiKs6DMz3bRI1X5tdiUdVRS+mo8t7W2p89jOW2AibyE+qs3b72w06g9MXIEHrn 232Q5U530fQdiOP8BdeaJ1rTpM06ys15a2pAUKjVPONpGRjk1/t2d1jR1VjmzkEjePo+ gXzNAHHro2c1iWBtjGQzDv4T3SPipdwq5OHdlFEp30vwH4JV0wkKBqS3mzDqvmfPag/n iG9iykWYGedTZazVzsHKRkWZ4DI6pqLuAvQQ6+Pm0S/SELQNHKZ1YNYAavAzyRJvdvru jfHHdEKzcw0daZY+YaYa5FckZeKCmNYeFR3WnddtC4CveWFjYMkb8hFFS4PVeCF1uElK ovXw== X-Gm-Message-State: ACrzQf2cEOt3G7/hjSnJwGjwDttLhmehP6g0SoP9Arb1WnGmzuChrueL qxxfzoxJ+cjxYCEZa6l4ng2/NH9a4xc= X-Google-Smtp-Source: AMsMyM7g0VOwbnviLzfwvnQcTkVzfJ9cXYUVngU9L0514DNalQYlfiRG/2GUJODK3K2GfMCZm30yyw== X-Received: by 2002:a05:622a:1ca:b0:35b:ad5a:478e with SMTP id t10-20020a05622a01ca00b0035bad5a478emr1257058qtw.325.1663268900502; Thu, 15 Sep 2022 12:08:20 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id i18-20020a05620a249200b006b5e296452csm4677975qkn.54.2022.09.15.12.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 12:08:19 -0700 (PDT) From: Florian Fainelli To: linux-arm-kernel@lists.infradead.org Cc: Florian Fainelli , Jim Quinlan , Broadcom internal kernel review list , Liang He , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] soc: bcm: brcmstb: biuctrl: Avoid double of_node_put() Date: Thu, 15 Sep 2022 12:08:09 -0700 Message-Id: <20220915190811.2576914-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220915_120824_618265_839EBDE0 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 9a073d4fbb18 ("soc: bcm: brcmstb: biuctrl: Add missing of_node_put()") added what was thought to be a missing of_node_put() but now causes a double of_node_put() to be called, once from setup_hifcpubiuctrl_regs() and another time from brcmstb_biuctrl_init(). Ensure that setup_hifcpubiuctrl_regs() is not calling of_node_put() since it is not obvious it does that on one of its parameters. Fixes: 9a073d4fbb18 ("soc: bcm: brcmstb: biuctrl: Add missing of_node_put()") Reported-by: Jim Quinlan Signed-off-by: Florian Fainelli Change-Id: I1c405c36c2f06c8b8c0f684143b7a52db7e809f0 --- drivers/soc/bcm/brcmstb/biuctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb/biuctrl.c index 1467bbd59690..e1d7b4543248 100644 --- a/drivers/soc/bcm/brcmstb/biuctrl.c +++ b/drivers/soc/bcm/brcmstb/biuctrl.c @@ -288,7 +288,6 @@ static int __init setup_hifcpubiuctrl_regs(struct device_node *np) if (BRCM_ID(family_id) == 0x7260 && BRCM_REV(family_id) == 0) cpubiuctrl_regs = b53_cpubiuctrl_no_wb_regs; out: - of_node_put(np); return ret; }