| Message ID | 20220922072950.9157-1-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr | expand |
On 22/09/22 12:59, Keerthy wrote: > The parent's input irq number is wrongly subtracted with 32 instead of > using the exact numbers in: > > https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html > > The GPIO interrupts are not working because of that. The toggling works > fine but interrupts are not firing. Fix the parent's input irq that > specifies the base for parent irq. > > Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM. > > Fixes: b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC") > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > index 34e7d577ae13..c89f28235812 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > @@ -60,7 +60,7 @@ > #interrupt-cells = <1>; > ti,sci = <&sms>; > ti,sci-dev-id = <148>; > - ti,interrupt-ranges = <8 360 56>; > + ti,interrupt-ranges = <8 392 56>; > }; > > main_pmx0: pinctrl@11c000 { > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 4d1bfabd1313..f0644851602c 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -65,7 +65,7 @@ > #interrupt-cells = <1>; > ti,sci = <&sms>; > ti,sci-dev-id = <125>; > - ti,interrupt-ranges = <16 928 16>; > + ti,interrupt-ranges = <16 960 16>; Reviewed-by: Vaishnav Achath <vaishnav.a@ti.com> > }; > > mcu_conf: syscon@40f00000 {
Hi Keerthy, On Thu, 22 Sep 2022 12:59:50 +0530, Keerthy wrote: > The parent's input irq number is wrongly subtracted with 32 instead of > using the exact numbers in: > > https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html > > The GPIO interrupts are not working because of that. The toggling works > fine but interrupts are not firing. Fix the parent's input irq that > specifies the base for parent irq. > > [...] I have applied the following to branch ti-k3-dts-next on [1]. Thank you! I have fixed up the commit sha to 12 characters (please do run checkpatch and usual checkers). I am choosing not to send this to 6.1 merge, since nothing actively looks broken requiring urgent fixup atm. [1/1] arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr commit: b8aa36c22da7d64c5a5d89ccb4a2abb9aeaab2e3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi index 34e7d577ae13..c89f28235812 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi @@ -60,7 +60,7 @@ #interrupt-cells = <1>; ti,sci = <&sms>; ti,sci-dev-id = <148>; - ti,interrupt-ranges = <8 360 56>; + ti,interrupt-ranges = <8 392 56>; }; main_pmx0: pinctrl@11c000 { diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi index 4d1bfabd1313..f0644851602c 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi @@ -65,7 +65,7 @@ #interrupt-cells = <1>; ti,sci = <&sms>; ti,sci-dev-id = <125>; - ti,interrupt-ranges = <16 928 16>; + ti,interrupt-ranges = <16 960 16>; }; mcu_conf: syscon@40f00000 {
The parent's input irq number is wrongly subtracted with 32 instead of using the exact numbers in: https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html The GPIO interrupts are not working because of that. The toggling works fine but interrupts are not firing. Fix the parent's input irq that specifies the base for parent irq. Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM. Fixes: b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC") Signed-off-by: Keerthy <j-keerthy@ti.com> --- arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)