From patchwork Fri Sep 30 10:09:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 12995110 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 684F9C433FE for ; Fri, 30 Sep 2022 10:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4fDSe1pZXzrQ7lC3x13ZW2IncYCDCSkoW2MIjeYpPZU=; b=jg8jj9OgfQ8EUI F8BYJ/QBOGhVGOnrp4YgdQl/0oHJAWXEEBt1ovN/nj/kkZYAuy4G2cBCz7FfU7oSo/4Aq6Tmq0MmA NcyMD9uqoxXUXpUe/lxzWySZ0HI6D0K3BvUJB9kFQ8r66czlhdOdAsYuhpBaFNsV/JU3HkgSAiyrc GHWsxbFKYRCJCrlmoLylBhGK+dz1Ec9BU/MXUAV3WgsaHrmtOfd8mjbN/8J9JFE99KXKTBlvDmFoX T2+t0iqAY+fgS0wtxHAqQoNx/gP4Piqg4g0QA9VQw+7eOEzpgXKuPY/QtEyTz5TDGp4YLzJyTFowb eTzfIP0ttYgpuhmze5nQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeCrb-008Ta8-94; Fri, 30 Sep 2022 10:03:23 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeCrY-008TXm-7s for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2022 10:03:21 +0000 Received: by mail-lf1-x135.google.com with SMTP id s6so6105591lfo.7 for ; Fri, 30 Sep 2022 03:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=TiijBohBoy/awqqmgRbwjxKUZoYOc3v1m9FkqUu5mOo=; b=F1e4sp7aLKMcHwE2RHtz+Ql+5lyoyiEokYhhYQ/QXVc96LCFIrT8+ajAPNp9M60JOd xtqPFupm2vs/+ek8hxCw3EMu9OkyrmZYLzym33XI9HPBwLYbt2UAA7/9pO/GcdojfyU6 OCon2iuA44ft7gM8CrWJ8SEqaqo7aPu9YVDgNjOfb9rdXwVK6TElggTg/tunD7zHUl6D 3mXPgY2974qd1s3JVB8nHHdQmsJg0pEXenzEr8MEQBamqN4bwZZYd8goE8YQayoEa3G6 f5Kb2vPkp1d/f9vHzieVQbEHimFeaZIy38teTntW83G+XoGGQeHC/W6osw0gwGegXcjk ySJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=TiijBohBoy/awqqmgRbwjxKUZoYOc3v1m9FkqUu5mOo=; b=ySUb74i9rjk32y6sHzjXc6CINPRdo3xFL7Oohj2vmPwu2OKEjUXSJTxZgJ+jBhSx6L yNQHbS45Jwc0EsBob2rGZ/ixslFe6AMtbN8yehRAWO8MD9cvb0q4n8bH0cL6HH/Imbeq tNM1tblCv3ea9/lP5NZ/AeDjWSsIk+y3SnTzMpPo/IEzrseG08QyEkJQCBk1L/y4cwvs 1x953q64WKKZlRfrKQMKdnmobRJ01WHrFiLEad8+Ka9/nWNrUvhAZ6/88veIlvUTNFZT WwIr6JlnDr37FbQyg7FeHRCCqQYlQ7sU/Vwui39EoI3GFn6AxGmAilqvs36s+1dzb2V/ fgoQ== X-Gm-Message-State: ACrzQf2KiUX3zwz9uJZymHj3fMjwSXRY2w98EbNn2HuTUgFDzORv1hqE N/9p1BM4ewh36+sFEoqG3Ao= X-Google-Smtp-Source: AMsMyM4+htJ/CXxmzYa4EpJ+aQ1OInRvJH88oS6U6jkAe47Vo+xzt1aksnI870SGmB6tQ7lcwVElPQ== X-Received: by 2002:ac2:4e14:0:b0:49b:67f3:e450 with SMTP id e20-20020ac24e14000000b0049b67f3e450mr3268762lfr.591.1664532194828; Fri, 30 Sep 2022 03:03:14 -0700 (PDT) Received: from localhost.localdomain (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id k15-20020a05651c10af00b0026c170ee13csm112272ljn.91.2022.09.30.03.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 03:03:13 -0700 (PDT) From: Marcus Folkesson To: "Rafael J . Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marcus Folkesson Subject: [PATCH] thermal: imx8mm_thermal: wait for a valid measurement Date: Fri, 30 Sep 2022 12:09:17 +0200 Message-Id: <20220930100917.498853-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_030320_321281_0BC64284 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Check if first measurement is still pending or if temperature is out of range. Return and try again later if that is the case. Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit") Signed-off-by: Marcus Folkesson --- drivers/thermal/imx8mm_thermal.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c index af666bd9e8d4..9dd60b940ef4 100644 --- a/drivers/thermal/imx8mm_thermal.c +++ b/drivers/thermal/imx8mm_thermal.c @@ -62,9 +62,15 @@ static int imx8mm_tmu_get_temp(void *data, int *temp) { struct tmu_sensor *sensor = data; struct imx8mm_tmu *tmu = sensor->priv; - u32 val; + bool ready; + unsigned long val; + + val = readl_relaxed(tmu->base + TRITSR); + ready = test_bit(probe_status_offset(1), &val); + if (!ready) + return -EAGAIN; - val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK; + val = val & TRITSR_TEMP0_VAL_MASK; *temp = val * 1000; if (*temp < VER1_TEMP_LOW_LIMIT) return -EAGAIN;