| Message ID | 20221001185715.495477-1-martin.botka@somainline.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125 | expand |
On 01/10/2022 20:57, Martin Botka wrote: > This patch adds binding for sm6125 SoC Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Fix it in all your patches, please. It is just "Add binding for SM6125 SoC". In the same time, your commit subject has redundant binding - first in prefix, second (redundant) in "Add binding for". So just: dt-bindings: iommu: arm-smmu: Add SM6125 Please fix both in all your patches. > > Signed-off-by: Martin Botka <martin.botka@somainline.org> With subject and commit msg fixes: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2022-10-01 20:57:15, Martin Botka wrote: > This patch adds binding for sm6125 SoC > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 9066e6df1ba1..21e15b88bae7 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -41,6 +41,7 @@ properties: > - qcom,sdm845-smmu-500 > - qcom,sdx55-smmu-500 > - qcom,sdx65-smmu-500 > + - qcom,sm6125-smmu-500 Shouldn't this be in the list above given that you switched the APPS to smmu-v2 in https://lore.kernel.org/linux-arm-msm/20221001185750.495874-1-martin.botka@somainline.org/ Alas, I don't remember which of the two compatibles is correct for this SoC, since both were seemingly working correctly... - Marijn > - qcom,sm6350-smmu-500 > - qcom,sm6375-smmu-500 > - qcom,sm8150-smmu-500 > -- > 2.37.3 >
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index 9066e6df1ba1..21e15b88bae7 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -41,6 +41,7 @@ properties: - qcom,sdm845-smmu-500 - qcom,sdx55-smmu-500 - qcom,sdx65-smmu-500 + - qcom,sm6125-smmu-500 - qcom,sm6350-smmu-500 - qcom,sm6375-smmu-500 - qcom,sm8150-smmu-500
This patch adds binding for sm6125 SoC Signed-off-by: Martin Botka <martin.botka@somainline.org> --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + 1 file changed, 1 insertion(+)