diff mbox series

ARM: dts: armada-xp-98dx3236: add interrupts for watchdog

Message ID 20221003212419.1280860-1-chris.packham@alliedtelesis.co.nz (mailing list archive)
State New, archived
Headers show
Series ARM: dts: armada-xp-98dx3236: add interrupts for watchdog | expand

Commit Message

Chris Packham Oct. 3, 2022, 9:24 p.m. UTC
The first interrupt is for the regular watchdog timeout. Normally the
RSTOUT line will trigger a reset before this interrupt fires but on
systems with a non-standard reset it may still trigger.

The second interrupt is for a timer1 which is used as a pre-timeout for
the watchdog.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Packham Oct. 4, 2022, 1:13 a.m. UTC | #1
Hi All,

On 4/10/22 10:24, Chris Packham wrote:
> The first interrupt is for the regular watchdog timeout. Normally the
> RSTOUT line will trigger a reset before this interrupt fires but on
> systems with a non-standard reset it may still trigger.
>
> The second interrupt is for a timer1 which is used as a pre-timeout for
> the watchdog.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

I just realized this is a duplicate of 
https://lore.kernel.org/linux-watchdog/20220211003257.2037332-2-chris.packham@alliedtelesis.co.nz/ 
(I did have a strange sense of deja vu when writing it).

Looks like that patch was reviewed and acked but never delivered. 
Gregory would you be able to pick it up now? The driver change has been 
in for a while.

> ---
>   arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 38a052a0312d..0e561dfc0ca9 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -286,6 +286,7 @@ &watchdog {
>   	compatible = "marvell,armada-xp-wdt";
>   	clocks = <&coreclk 2>, <&refclk>;
>   	clock-names = "nbclk", "fixed";
> +	interrupts = <93>, <38>;
>   };
>   
>   &cpurst {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
index 38a052a0312d..0e561dfc0ca9 100644
--- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
+++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
@@ -286,6 +286,7 @@  &watchdog {
 	compatible = "marvell,armada-xp-wdt";
 	clocks = <&coreclk 2>, <&refclk>;
 	clock-names = "nbclk", "fixed";
+	interrupts = <93>, <38>;
 };
 
 &cpurst {