diff mbox series

[1/1] irqchip: irq-imx-mu-msi: fixed wrong register offset for 8ulp

Message ID 20221004202414.216577-1-Frank.Li@nxp.com (mailing list archive)
State New, archived
Headers show
Series [1/1] irqchip: irq-imx-mu-msi: fixed wrong register offset for 8ulp | expand

Commit Message

Frank Li Oct. 4, 2022, 8:24 p.m. UTC 
Offset 0x124 should be IMX_MU_TSR, not IMX_MU_GSR

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/irqchip/irq-imx-mu-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Oct. 4, 2022, 9:27 p.m. UTC | #1 
Hi Frank,

On Tue, Oct 4, 2022 at 5:24 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> Offset 0x124 should be IMX_MU_TSR, not IMX_MU_GSR
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

You missed passing Reported-by and Fixes tag.
Marc Zyngier Oct. 4, 2022, 10:41 p.m. UTC | #2 
On Tue, 04 Oct 2022 22:27:32 +0100,
Fabio Estevam <festevam@gmail.com> wrote:
> 
> Hi Frank,
> 
> On Tue, Oct 4, 2022 at 5:24 PM Frank Li <Frank.Li@nxp.com> wrote:
> >
> > Offset 0x124 should be IMX_MU_TSR, not IMX_MU_GSR
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> You missed passing Reported-by and Fixes tag.

I fixed that locally. Thanks for CC'ing Colin though.

	M.
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c
index b62139dc36e82..229039eda1b1f 100644
--- a/drivers/irqchip/irq-imx-mu-msi.c
+++ b/drivers/irqchip/irq-imx-mu-msi.c
@@ -292,7 +292,7 @@  static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
 	.xSR    = {
 			[IMX_MU_SR]  = 0xC,
 			[IMX_MU_GSR] = 0x118,
-			[IMX_MU_GSR] = 0x124,
+			[IMX_MU_TSR] = 0x124,
 			[IMX_MU_RSR] = 0x12C,
 		  },
 	.xCR    = {