From patchwork Tue Oct 11 18:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13004259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C396C433FE for ; Tue, 11 Oct 2022 18:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2kg110OExgIL/zC4lP0RiBAcQ5c5lJvSNHllua+v7nk=; b=TCmzbwEBB0/jYc e0AV4KV1d1QH6lYKizhaZppph+r3i9j+sSsgJb57xWNkGlR/ZOZlmT7qxcfHmf0/cH0GWeAKQCOYD dxZzxZz5hxgB9fENhn2h1wzyeDzWw5VEpyFHgt2Ne2PxEEi+YL9cIL9BHf1dbdqMtceihoNDL19bu lrxLjMy5GP37En5NRJ8fMGzYHZBve+ugmBnHnC2AnZo68EeixOcltPG0Rftx7lLZeiHE4bL9lLHGf mo67LWH2Qt3uI16/JTlei4kktiji4vNKQ5d8iV90a5HAfFj6KEQhOKYcR4oLVhqETEB8y6uRpgc+c hgWdUJdNwcEWjM+dXmKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiKDj-005TTG-U0; Tue, 11 Oct 2022 18:43:17 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiKCu-005TBm-AC; Tue, 11 Oct 2022 18:42:27 +0000 Received: by mail-qt1-x835.google.com with SMTP id c23so4827758qtw.8; Tue, 11 Oct 2022 11:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=jC9v6x5O9g4o36lTWYhNYvUXqkkWlvK03fmUWelD46Y=; b=QJXGNK69c45gXxMdpzsU32P1osw4qt8d4ezCrzK7p+V9A9LWM7zYJYKdkJi4RCVhU/ xlprNjlA0EEFoHkTc98wUvsr0TGnRoDMxZEQNJ/2AVBdNKFGpAKU6W1udWq4eeNdpFpj 3qLuT1Xli21zAtRxMdp8YsiAtmUKH5nPqzUL8MpDKW4sFAT+30a2U3pzok4z9qJGHjzk Lkh/5rsq73Ib6fXEJfZboA1ADYW8kK4sdtBUb1F3qYC8vqmiys/xoge+3oX4Eo0/beDF Sg+1iuecagwXvBNWP+pfASw79MbYknWYbyaFHSgHDDdB6bimib1Ir8YC2509qr+R4PaE 8x3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jC9v6x5O9g4o36lTWYhNYvUXqkkWlvK03fmUWelD46Y=; b=xb23/zmS5+9U/4d4YyGfcvqy5NnoHsHlCJl5iA+ygwMH6I/hF2bbdlkR5aESJlmWNF vk4HdXHYhn2QK0xMzXvv6BnxBg7UxpuSQP8AlaszA8J5OIBN8+U4LMX/3nIIlWYePXUK seaTgxZ6l99FSyvAFurS1kKrvEK6D7H7NwZvmPeo7mubxTlTTRqsws74tXWd6Ay6sdkg jWUq3Lm8WZYtI3C877b6IErq6BLmjitxL0+RFF9BXKelP9ue/VagCo3Ev5bUb14x4HS5 KxIpm6W7h4KWRsPfvrz3aiCLf7JfCM/DQqWvsh6r6DzzsmI2YvJWCYx0BTnyn1LPtslY spmA== X-Gm-Message-State: ACrzQf2wMX3B0dp3o9zAK/n7AqNAXtTU9huYPA7W856PeA3z/6hAVqom i63bCQdylhyDrV+rSvUxJhc= X-Google-Smtp-Source: AMsMyM7LATMcDiFcvI+0/DRZQnhodXci0t2uK77a9y8u6aghVCj0Oo0ASbgemMCgyldZFJrJqqrrHw== X-Received: by 2002:ac8:5751:0:b0:39c:b848:198f with SMTP id 17-20020ac85751000000b0039cb848198fmr2170312qtx.429.1665513739432; Tue, 11 Oct 2022 11:42:19 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id fc8-20020a05622a488800b003938a65479bsm10961732qtb.10.2022.10.11.11.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 11:42:18 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/5] PCI: brcmstb: Functions needlessly specified as "inline" Date: Tue, 11 Oct 2022 14:42:09 -0400 Message-Id: <20221011184211.18128-5-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221011184211.18128-1-jim2101024@gmail.com> References: <20221011184211.18128-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221011_114224_380727_D00DDD6A X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org A number of inline functions are called rarely and/or are not time-critical. Take out the "inline" and let the compiler do its work. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Reviewed-by: Bjorn Helgaas --- drivers/pci/controller/pcie-brcmstb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index c7210cec1f58..e3045f1eadbc 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -723,7 +723,7 @@ static void __iomem *brcm7425_pcie_map_bus(struct pci_bus *bus, return base + DATA_ADDR(pcie); } -static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) { u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; @@ -733,7 +733,7 @@ static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) { u32 tmp, mask = RGR1_SW_INIT_1_INIT_7278_MASK; u32 shift = RGR1_SW_INIT_1_INIT_7278_SHIFT; @@ -743,7 +743,7 @@ static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) { if (WARN_ONCE(!pcie->perst_reset, "missing PERST# reset controller\n")) return; @@ -754,7 +754,7 @@ static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) reset_control_deassert(pcie->perst_reset); } -static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) { u32 tmp; @@ -764,7 +764,7 @@ static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) writel(tmp, pcie->base + PCIE_MISC_PCIE_CTRL); } -static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) { u32 tmp; @@ -773,7 +773,7 @@ static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, +static int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, u64 *rc_bar2_size, u64 *rc_bar2_offset) {