From patchwork Wed Oct 12 14:00:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13005076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2D42C433FE for ; Wed, 12 Oct 2022 14:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/EaFLKDKIhhMlvKZyYb+YGe6KcvVPuyU6Qt2eLdtUd4=; b=0Xfv8bTV0kmEFx Pb/KQMSzQtB1863xIqyBnosrsW+9Fi6UpkdTG1FWsZ15/lIpWcHn1K2Aap93RRnQ8XrYce+oNk63N ZAY9scjolulYOk0R5gXQXSy8C+xTpGM2pE9YlqZDQ7rUfUE49bb15WMwvLL2hu/82CSksnAfpFjP/ wrn52Oiyuis1krLeT/c9tKT8RxjyrpFPp+9GSl1DbtSJGcXpEUVAbPV1vjz5GJYE22UN8Rwxrz2oB FTmBKsruOcVyWVsfFm1bNzs66UGhi0ReNoxmdhAU1EXhYisLgPkqvUdoM05Qufi3MXBG4cGejaE5y QrLCcZlOln6tldaZYDBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oicHw-008J3s-5c; Wed, 12 Oct 2022 14:00:48 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oicHt-008J35-Rh for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 14:00:47 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oicHl-0004J9-GI; Wed, 12 Oct 2022 16:00:37 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oicHk-0016Tb-86; Wed, 12 Oct 2022 16:00:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oicHj-007N3Q-95; Wed, 12 Oct 2022 16:00:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer Date: Wed, 12 Oct 2022 16:00:32 +0200 Message-Id: <20221012140032.113363-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2193; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=go2uoLVLTeknTfindMLyukuO+Mr+RUT3ge5KLA2yz7U=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjRsh9XAZH6xG3bldx+P798iuNwqs6cU8bmOGQfunc s3naMFqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY0bIfQAKCRDB/BR4rcrsCUDKB/ wMyx4fYPQhFp9DHbOa4dhbykwNlaQuylcfdJCAWjyKs5ZH0GUHosbX5e2EIjhlyIi4uYfw+l+vb0Qm 50LK3N2G0NAqrWRSDRQgaSORB6yokJ6rJM+EmX8n+39Usi2io6GAAwY3FFwZ09I2oEexnnBiBsxyW9 qURSjrcXUKz6Lmnw1lw4dR6mO/TEamcPsGIiwi+5j/N+jr0b5a6YRNG7+ByaC02mjOiV7E5fNhZk6b cofQWf70Xo/9mQ4bWmQa08l7Q8RcWLWLcA80zwV2T+3esmfRFz0ZqOPC9vtMmcyC2QSW67R/zlLpt9 X8L0TEM6NCpVfrQS/kEGFYmtwj7wFU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_070045_914017_3A128A3F X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The probe function stores the sr_info pointer using platform_set_drvdata(). Use the corresponding platform_get_drvdata() to retrieve that pointer in the remove and shutdown functions. This simplifies these functions and makes error handling unnecessary. This is a good thing as at least for .remove() returning an error code doesn't have the desired effect. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Reviewed-by: Tony Lindgren --- drivers/soc/ti/smartreflex.c | 30 ++---------------------------- 1 file changed, 2 insertions(+), 28 deletions(-) base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index ad2bb72e640c..1d0b50feae44 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -940,21 +940,8 @@ static int omap_sr_probe(struct platform_device *pdev) static int omap_sr_remove(struct platform_device *pdev) { - struct omap_sr_data *pdata = pdev->dev.platform_data; struct device *dev = &pdev->dev; - struct omap_sr *sr_info; - - if (!pdata) { - dev_err(&pdev->dev, "%s: platform data missing\n", __func__); - return -EINVAL; - } - - sr_info = _sr_lookup(pdata->voltdm); - if (IS_ERR(sr_info)) { - dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", - __func__); - return PTR_ERR(sr_info); - } + struct omap_sr *sr_info = platform_get_drvdata(pdev); if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info); @@ -968,20 +955,7 @@ static int omap_sr_remove(struct platform_device *pdev) static void omap_sr_shutdown(struct platform_device *pdev) { - struct omap_sr_data *pdata = pdev->dev.platform_data; - struct omap_sr *sr_info; - - if (!pdata) { - dev_err(&pdev->dev, "%s: platform data missing\n", __func__); - return; - } - - sr_info = _sr_lookup(pdata->voltdm); - if (IS_ERR(sr_info)) { - dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", - __func__); - return; - } + struct omap_sr *sr_info = platform_get_drvdata(pdev); if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info);