| Message ID | 20221013152212.416661-7-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM64 MediaTek devicetree fixes - Part 1 | expand |
On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote: > Update the names to regulator-usb-p{0-3}-vbus to fix > unit_address_vs_reg > warnings for those. > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712") > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > index 638908773706..d31a194124c9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { > id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; > }; > > - usb_p0_vbus: regulator@2 { > + usb_p0_vbus: regulator-usb-p0-vbus { Can we modify dt-binding of fixed regulator instead of changing the node name, since all nodes using fixed regulator may need be changed. > compatible = "regulator-fixed"; > regulator-name = "p0_vbus"; > regulator-min-microvolt = <5000000>; > @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 { > enable-active-high; > }; > > - usb_p1_vbus: regulator@3 { > + usb_p1_vbus: regulator-usb-p1-vbus { > compatible = "regulator-fixed"; > regulator-name = "p1_vbus"; > regulator-min-microvolt = <5000000>; > @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 { > enable-active-high; > }; > > - usb_p2_vbus: regulator@4 { > + usb_p2_vbus: regulator-usb-p2-vbus { > compatible = "regulator-fixed"; > regulator-name = "p2_vbus"; > regulator-min-microvolt = <5000000>; > @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 { > enable-active-high; > }; > > - usb_p3_vbus: regulator@5 { > + usb_p3_vbus: regulator-usb-p3-vbus { > compatible = "regulator-fixed"; > regulator-name = "p3_vbus"; > regulator-min-microvolt = <5000000>;
Il 14/10/22 04:43, Chunfeng Yun ha scritto: > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote: >> Update the names to regulator-usb-p{0-3}-vbus to fix >> unit_address_vs_reg >> warnings for those. >> >> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712") >> Signed-off-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> --- >> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> index 638908773706..d31a194124c9 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { >> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; >> }; >> >> - usb_p0_vbus: regulator@2 { >> + usb_p0_vbus: regulator-usb-p0-vbus { > Can we modify dt-binding of fixed regulator instead of changing the > node name, > since all nodes using fixed regulator may need be changed. > These regulators have no MMIO, nor need any index, so it would be simply wrong to change the binding and leave them as they are here in the devicetree. Regards, Angelo
On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote: > Il 14/10/22 04:43, Chunfeng Yun ha scritto: > > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno > > wrote: > > > Update the names to regulator-usb-p{0-3}-vbus to fix > > > unit_address_vs_reg > > > warnings for those. > > > > > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for > > > MT2712") > > > Signed-off-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@collabora.com> > > > --- > > > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > index 638908773706..d31a194124c9 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { > > > id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; > > > }; > > > > > > - usb_p0_vbus: regulator@2 { > > > + usb_p0_vbus: regulator-usb-p0-vbus { > > > > Can we modify dt-binding of fixed regulator instead of changing the > > node name, > > since all nodes using fixed regulator may need be changed. > > > > These regulators have no MMIO, nor need any index, so it would be > simply > wrong to change the binding and leave them as they are here in the > devicetree. You are right, then many files need be modified? Thanks > > Regards, > Angelo
Il 21/10/22 08:25, Chunfeng Yun ha scritto: > On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote: >> Il 14/10/22 04:43, Chunfeng Yun ha scritto: >>> On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno >>> wrote: >>>> Update the names to regulator-usb-p{0-3}-vbus to fix >>>> unit_address_vs_reg >>>> warnings for those. >>>> >>>> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for >>>> MT2712") >>>> Signed-off-by: AngeloGioacchino Del Regno < >>>> angelogioacchino.delregno@collabora.com> >>>> --- >>>> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> index 638908773706..d31a194124c9 100644 >>>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { >>>> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; >>>> }; >>>> >>>> - usb_p0_vbus: regulator@2 { >>>> + usb_p0_vbus: regulator-usb-p0-vbus { >>> >>> Can we modify dt-binding of fixed regulator instead of changing the >>> node name, >>> since all nodes using fixed regulator may need be changed. >>> >> >> These regulators have no MMIO, nor need any index, so it would be >> simply >> wrong to change the binding and leave them as they are here in the >> devicetree. > You are right, then many files need be modified? > Yes Chunfeng, many files need to be modified due to mistakes made in the past. No big deal though: as long as we're all aware of what needs to happen, it's fine! Cheers, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts index 638908773706..d31a194124c9 100644 --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; }; - usb_p0_vbus: regulator@2 { + usb_p0_vbus: regulator-usb-p0-vbus { compatible = "regulator-fixed"; regulator-name = "p0_vbus"; regulator-min-microvolt = <5000000>; @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 { enable-active-high; }; - usb_p1_vbus: regulator@3 { + usb_p1_vbus: regulator-usb-p1-vbus { compatible = "regulator-fixed"; regulator-name = "p1_vbus"; regulator-min-microvolt = <5000000>; @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 { enable-active-high; }; - usb_p2_vbus: regulator@4 { + usb_p2_vbus: regulator-usb-p2-vbus { compatible = "regulator-fixed"; regulator-name = "p2_vbus"; regulator-min-microvolt = <5000000>; @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 { enable-active-high; }; - usb_p3_vbus: regulator@5 { + usb_p3_vbus: regulator-usb-p3-vbus { compatible = "regulator-fixed"; regulator-name = "p3_vbus"; regulator-min-microvolt = <5000000>;
Update the names to regulator-usb-p{0-3}-vbus to fix unit_address_vs_reg warnings for those. Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)