diff mbox series

[01/17] ARM: at91: remove stale MAINTAINER file entries

Message ID 20221019150410.3851944-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series [01/17] ARM: at91: remove stale MAINTAINER file entries | expand

Commit Message

Arnd Bergmann Oct. 19, 2022, 3:03 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Going through the entries of recently removed machine types,
I found these two that were removed a long time ago.

Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 MAINTAINERS | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Aaro Koskinen Oct. 19, 2022, 5:15 p.m. UTC | #1 
Hi,

On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All board support that was marked as 'unused' earlier can
> now be removed, leaving the five machines that that still
> had someone using them in 2022, or that are supported in
> qemu.
[...]
>  config OMAP_OSK_MISTRAL
>  	bool "Mistral QVGA board Support"
>  	depends on MACH_OMAP_OSK
> -	depends on UNUSED_BOARD_FILES
>  	help
>  	  The OSK supports an optional add-on board with a Quarter-VGA
>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
>  	  and camera connector.  Say Y here if you have this board.

Shouldn't this go away as well?

A.
Wolfram Sang Oct. 19, 2022, 7:30 p.m. UTC | #2 
On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All board support that was marked as 'unused' earlier can
> now be removed, leaving the five machines that that still
> had someone using them in 2022, or that are supported in
> qemu.
> 
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Wolfram Sang <wsa@kernel.org>
Arnd Bergmann Oct. 20, 2022, 7:11 a.m. UTC | #3 
On Wed, Oct 19, 2022, at 19:15, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> All board support that was marked as 'unused' earlier can
>> now be removed, leaving the five machines that that still
>> had someone using them in 2022, or that are supported in
>> qemu.
> [...]
>>  config OMAP_OSK_MISTRAL
>>  	bool "Mistral QVGA board Support"
>>  	depends on MACH_OMAP_OSK
>> -	depends on UNUSED_BOARD_FILES
>>  	help
>>  	  The OSK supports an optional add-on board with a Quarter-VGA
>>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
>>  	  and camera connector.  Say Y here if you have this board.
>
> Shouldn't this go away as well?

No, this one was incorrectly annotated, it's not actually
a board but it's an option for the OSK board that is not
getting removed. I considered making a separate patch
for removing the dependency, but that didn't seem worth it.

    Arnd
Aaro Koskinen Oct. 20, 2022, 7:35 p.m. UTC | #4 
Hi,

On Thu, Oct 20, 2022 at 09:11:11AM +0200, Arnd Bergmann wrote:
> On Wed, Oct 19, 2022, at 19:15, Aaro Koskinen wrote:
> > On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
> >> All board support that was marked as 'unused' earlier can
> >> now be removed, leaving the five machines that that still
> >> had someone using them in 2022, or that are supported in
> >> qemu.
> > [...]
> >>  config OMAP_OSK_MISTRAL
> >>  	bool "Mistral QVGA board Support"
> >>  	depends on MACH_OMAP_OSK
> >> -	depends on UNUSED_BOARD_FILES
> >>  	help
> >>  	  The OSK supports an optional add-on board with a Quarter-VGA
> >>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
> >>  	  and camera connector.  Say Y here if you have this board.
> >
> > Shouldn't this go away as well?
> 
> No, this one was incorrectly annotated, it's not actually
> a board but it's an option for the OSK board that is not
> getting removed. I considered making a separate patch
> for removing the dependency, but that didn't seem worth it.

OK. For the record, I don't think anyone has this add-on board anymore,
and it has probably never been tested with the mainline kernel, so
it's likely in the "dead code" category... Maybe it could be changed to
"BROKEN", then the related OSK LCD panel stuff could be deleted later
on too.

A.
Arnd Bergmann Oct. 21, 2022, 6:52 a.m. UTC | #5 
On Thu, Oct 20, 2022, at 21:35, Aaro Koskinen wrote:
> On Thu, Oct 20, 2022 at 09:11:11AM +0200, Arnd Bergmann wrote:
>> On Wed, Oct 19, 2022, at 19:15, Aaro Koskinen wrote:
>> > On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
>> >> All board support that was marked as 'unused' earlier can
>> >> now be removed, leaving the five machines that that still
>> >> had someone using them in 2022, or that are supported in
>> >> qemu.
>> > [...]
>> >>  config OMAP_OSK_MISTRAL
>> >>  	bool "Mistral QVGA board Support"
>> >>  	depends on MACH_OMAP_OSK
>> >> -	depends on UNUSED_BOARD_FILES
>> >>  	help
>> >>  	  The OSK supports an optional add-on board with a Quarter-VGA
>> >>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
>> >>  	  and camera connector.  Say Y here if you have this board.
>> >
>> > Shouldn't this go away as well?
>> 
>> No, this one was incorrectly annotated, it's not actually
>> a board but it's an option for the OSK board that is not
>> getting removed. I considered making a separate patch
>> for removing the dependency, but that didn't seem worth it.
>
> OK. For the record, I don't think anyone has this add-on board anymore,
> and it has probably never been tested with the mainline kernel, so
> it's likely in the "dead code" category... Maybe it could be changed to
> "BROKEN", then the related OSK LCD panel stuff could be deleted later
> on too.

Ok, good to know. I left it in place for now because Tony originally
listed it as a likely used machine along with NOKIA770 and
AMS_DELTA [1], but I don't have anyone listed specifically as a
user for it.

It's not too late to revisit this list if you think it helps to
get rid of it. I can see that drivers/mtd/tps65010.c and
drivers/pcmcia/omap_cf.c become orphaned without it and can
probably get removed as well then.

      Arnd

[1] https://lore.kernel.org/linux-arm-kernel/20220721150320.GA9385@macbook.musicnaut.iki.fi/
Nicolas Ferre Oct. 21, 2022, 8:33 a.m. UTC | #6 
On 19/10/2022 at 17:03, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Going through the entries of recently removed machine types,
> I found these two that were removed a long time ago.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>


> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   MAINTAINERS | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cf0f18502372..aedb7c008dd6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1798,16 +1798,6 @@ M:       Lennert Buytenhek <kernel@wantstofly.org>
>   L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>   S:     Maintained
> 
> -ARM/AFEB9260 MACHINE SUPPORT
> -M:     Sergey Lapin <slapin@ossfans.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -S:     Maintained
> -
> -ARM/AJECO 1ARM MACHINE SUPPORT
> -M:     Lennert Buytenhek <kernel@wantstofly.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -S:     Maintained
> -

Yes, both removed by fb3642ebb52cfab8eaa52fea677abec4d92182a0 during 
v3.18..v3.19.

>   ARM/Allwinner SoC Clock Support
>   M:     Emilio López <emilio@elopez.com.ar>
>   S:     Maintained

Thanks Arnd! Best regards,
   Nicolas
Nicolas Ferre Oct. 21, 2022, 9:45 a.m. UTC | #7 
On 21/10/2022 at 10:33, Nicolas Ferre wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 19/10/2022 at 17:03, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Going through the entries of recently removed machine types,
>> I found these two that were removed a long time ago.
>>
>> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

BTW, isn't there the need to remove it from mach-types as well?

v6.0:arch/arm/tools/mach-types:afeb9260  MACH_AFEB9260 AFEB9260  1859

>> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
>> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>    MAINTAINERS | 10 ----------
>>    1 file changed, 10 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cf0f18502372..aedb7c008dd6 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1798,16 +1798,6 @@ M:       Lennert Buytenhek <kernel@wantstofly.org>
>>    L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>>    S:     Maintained
>>
>> -ARM/AFEB9260 MACHINE SUPPORT
>> -M:     Sergey Lapin <slapin@ossfans.org>
>> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> -S:     Maintained
>> -
>> -ARM/AJECO 1ARM MACHINE SUPPORT
>> -M:     Lennert Buytenhek <kernel@wantstofly.org>
>> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> -S:     Maintained
>> -
> 
> Yes, both removed by fb3642ebb52cfab8eaa52fea677abec4d92182a0 during
> v3.18..v3.19.
> 
>>    ARM/Allwinner SoC Clock Support
>>    M:     Emilio López <emilio@elopez.com.ar>
>>    S:     Maintained
> 
> Thanks Arnd! Best regards,
>     Nicolas
> 
> 
> --
> Nicolas Ferre
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Lee Jones Oct. 21, 2022, 9:50 a.m. UTC | #8 
On Wed, 19 Oct 2022, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> All board support that was marked as 'unused' earlier can
> now be removed, leaving the five machines that that still
> had someone using them in 2022, or that are supported in
> qemu.
> 
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  MAINTAINERS                             |   2 -
>  arch/arm/Kconfig.debug                  |  36 +-
>  arch/arm/configs/omap1_defconfig        |   2 -
>  arch/arm/mach-omap1/Kconfig             |  93 +---
>  arch/arm/mach-omap1/Makefile            |  18 -
>  arch/arm/mach-omap1/board-fsample.c     | 366 ---------------
>  arch/arm/mach-omap1/board-generic.c     |  85 ----
>  arch/arm/mach-omap1/board-h2-mmc.c      |  74 ---
>  arch/arm/mach-omap1/board-h2.c          | 448 ------------------
>  arch/arm/mach-omap1/board-h2.h          |  38 --
>  arch/arm/mach-omap1/board-h3-mmc.c      |  64 ---
>  arch/arm/mach-omap1/board-h3.c          | 455 ------------------
>  arch/arm/mach-omap1/board-h3.h          |  35 --
>  arch/arm/mach-omap1/board-htcherald.c   | 585 ------------------------
>  arch/arm/mach-omap1/board-innovator.c   | 481 -------------------
>  arch/arm/mach-omap1/board-nand.c        |  33 --
>  arch/arm/mach-omap1/board-palmtt.c      | 285 ------------
>  arch/arm/mach-omap1/board-palmz71.c     | 300 ------------
>  arch/arm/mach-omap1/board-perseus2.c    | 333 --------------
>  arch/arm/mach-omap1/fpga.c              | 186 --------
>  arch/arm/mach-omap1/fpga.h              |  49 --
>  arch/arm/mach-omap1/gpio7xx.c           | 272 -----------
>  drivers/i2c/busses/Kconfig              |   2 +-
>  drivers/mfd/Kconfig                     |   2 +-

Acked-by: Lee Jones <lee@kernel.org>

>  drivers/mmc/host/Kconfig                |   2 +-
>  drivers/usb/gadget/udc/Kconfig          |   2 +-
>  drivers/usb/host/Kconfig                |   2 +-
>  include/linux/platform_data/leds-omap.h |  19 -
>  28 files changed, 12 insertions(+), 4257 deletions(-)
>  delete mode 100644 arch/arm/mach-omap1/board-fsample.c
>  delete mode 100644 arch/arm/mach-omap1/board-generic.c
>  delete mode 100644 arch/arm/mach-omap1/board-h2-mmc.c
>  delete mode 100644 arch/arm/mach-omap1/board-h2.c
>  delete mode 100644 arch/arm/mach-omap1/board-h2.h
>  delete mode 100644 arch/arm/mach-omap1/board-h3-mmc.c
>  delete mode 100644 arch/arm/mach-omap1/board-h3.c
>  delete mode 100644 arch/arm/mach-omap1/board-h3.h
>  delete mode 100644 arch/arm/mach-omap1/board-htcherald.c
>  delete mode 100644 arch/arm/mach-omap1/board-innovator.c
>  delete mode 100644 arch/arm/mach-omap1/board-nand.c
>  delete mode 100644 arch/arm/mach-omap1/board-palmtt.c
>  delete mode 100644 arch/arm/mach-omap1/board-palmz71.c
>  delete mode 100644 arch/arm/mach-omap1/board-perseus2.c
>  delete mode 100644 arch/arm/mach-omap1/fpga.c
>  delete mode 100644 arch/arm/mach-omap1/fpga.h
>  delete mode 100644 arch/arm/mach-omap1/gpio7xx.c
>  delete mode 100644 include/linux/platform_data/leds-omap.h
Aaro Koskinen Oct. 21, 2022, 11:11 a.m. UTC | #9 
Hi,

On Fri, Oct 21, 2022 at 08:52:10AM +0200, Arnd Bergmann wrote:
> On Thu, Oct 20, 2022, at 21:35, Aaro Koskinen wrote:
> > On Thu, Oct 20, 2022 at 09:11:11AM +0200, Arnd Bergmann wrote:
> >> On Wed, Oct 19, 2022, at 19:15, Aaro Koskinen wrote:
> >> > On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
> >> >> All board support that was marked as 'unused' earlier can
> >> >> now be removed, leaving the five machines that that still
> >> >> had someone using them in 2022, or that are supported in
> >> >> qemu.
> >> > [...]
> >> >>  config OMAP_OSK_MISTRAL
> >> >>  	bool "Mistral QVGA board Support"
> >> >>  	depends on MACH_OMAP_OSK
> >> >> -	depends on UNUSED_BOARD_FILES
> >> >>  	help
> >> >>  	  The OSK supports an optional add-on board with a Quarter-VGA
> >> >>  	  touchscreen, PDA-ish buttons, a resume button, bicolor LED,
> >> >>  	  and camera connector.  Say Y here if you have this board.
> >> >
> >> > Shouldn't this go away as well?
> >> 
> >> No, this one was incorrectly annotated, it's not actually
> >> a board but it's an option for the OSK board that is not
> >> getting removed. I considered making a separate patch
> >> for removing the dependency, but that didn't seem worth it.
> >
> > OK. For the record, I don't think anyone has this add-on board anymore,
> > and it has probably never been tested with the mainline kernel, so
> > it's likely in the "dead code" category... Maybe it could be changed to
> > "BROKEN", then the related OSK LCD panel stuff could be deleted later
> > on too.
> 
> Ok, good to know. I left it in place for now because Tony originally
> listed it as a likely used machine along with NOKIA770 and
> AMS_DELTA [1], but I don't have anyone listed specifically as a
> user for it.
> 
> It's not too late to revisit this list if you think it helps to
> get rid of it. I can see that drivers/mtd/tps65010.c and
> drivers/pcmcia/omap_cf.c become orphaned without it and can
> probably get removed as well then.

I was only referring to this Mistral add-on board and related display
drivers.

The main OSK board support is still needed and used.

A.
Greg KH Oct. 22, 2022, 10:24 a.m. UTC | #10 
On Wed, Oct 19, 2022 at 05:03:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All board support that was marked as 'unused' earlier can
> now be removed, leaving the five machines that that still
> had someone using them in 2022, or that are supported in
> qemu.
> 
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Lindgren Oct. 24, 2022, 5:45 a.m. UTC | #11 
* Arnd Bergmann <arnd@kernel.org> [221019 15:08]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All board support that was marked as 'unused' earlier can
> now be removed, leaving the five machines that that still
> had someone using them in 2022, or that are supported in
> qemu.

Acked-by: Tony Lindgren <tony@atomide.com>
Tony Lindgren Oct. 24, 2022, 5:49 a.m. UTC | #12 
* Aaro Koskinen <aaro.koskinen@iki.fi> [221021 11:02]:
> I was only referring to this Mistral add-on board and related display
> drivers.
> 
> The main OSK board support is still needed and used.

I'm pretty sure I have that display, but I was booting my OSK in a
rack anyways so I rarely saw the LCD in use. No objections from me
for removing the LCD support for OSK if nobody is using it.

Regards,

Tony
Arnd Bergmann Oct. 24, 2022, 4:02 p.m. UTC | #13 
On Mon, Oct 24, 2022, at 07:49, Tony Lindgren wrote:
> * Aaro Koskinen <aaro.koskinen@iki.fi> [221021 11:02]:
>> I was only referring to this Mistral add-on board and related display
>> drivers.
>> 
>> The main OSK board support is still needed and used.

Ok, got it.

> I'm pretty sure I have that display, but I was booting my OSK in a
> rack anyways so I rarely saw the LCD in use. No objections from me
> for removing the LCD support for OSK if nobody is using it.

I was going to leave Mistral in, thinking it's just a device definition,
but upon closer look I found that this is a somewhat annoyingly
written part that hardcodes GPIO numbers in unusual ways, so I'm
adding a patch to remove it now.

     Arnd
Tony Lindgren Oct. 25, 2022, 8:08 a.m. UTC | #14 
* Arnd Bergmann <arnd@arndb.de> [221024 15:53]:
> On Mon, Oct 24, 2022, at 07:49, Tony Lindgren wrote:
> > * Aaro Koskinen <aaro.koskinen@iki.fi> [221021 11:02]:
> >> I was only referring to this Mistral add-on board and related display
> >> drivers.
> >> 
> >> The main OSK board support is still needed and used.
> 
> Ok, got it.
> 
> > I'm pretty sure I have that display, but I was booting my OSK in a
> > rack anyways so I rarely saw the LCD in use. No objections from me
> > for removing the LCD support for OSK if nobody is using it.
> 
> I was going to leave Mistral in, thinking it's just a device definition,
> but upon closer look I found that this is a somewhat annoyingly
> written part that hardcodes GPIO numbers in unusual ways, so I'm
> adding a patch to remove it now.

OK sounds good to me.

Thanks,

Tony
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index cf0f18502372..aedb7c008dd6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1798,16 +1798,6 @@  M:	Lennert Buytenhek <kernel@wantstofly.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 
-ARM/AFEB9260 MACHINE SUPPORT
-M:	Sergey Lapin <slapin@ossfans.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-S:	Maintained
-
-ARM/AJECO 1ARM MACHINE SUPPORT
-M:	Lennert Buytenhek <kernel@wantstofly.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-S:	Maintained
-
 ARM/Allwinner SoC Clock Support
 M:	Emilio López <emilio@elopez.com.ar>
 S:	Maintained