| Message ID | 20221031-b4-odroid-go-ultra-initial-v1-1-42e3dbea86d5@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: amlogic: add initial Odroid Go Ultra DTS | expand |
Hi Neil, On Mon, Oct 31, 2022 at 5:47 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff > to its two PMICs in order, this represents the poweroff scheme needed to complet s/complet/complete/ > a clean poeroff of the system. s/poeroff/poweroff/ Please wait with re-sending this patch in case the dt-bindings and reset experts have more to say than finding typos. Best regards, Martin
On 31/10/2022 22:16, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Oct 31, 2022 at 5:47 PM Neil Armstrong > <neil.armstrong@linaro.org> wrote: >> >> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> to its two PMICs in order, this represents the poweroff scheme needed to complet > s/complet/complete/ >> a clean poeroff of the system. > s/poeroff/poweroff/ > > Please wait with re-sending this patch in case the dt-bindings and > reset experts have more to say than finding typos. Thx for spotting those typos ! > > > Best regards, > Martin Neil
On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote: > The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff > to its two PMICs in order, this represents the poweroff scheme needed to complet > a clean poeroff of the system. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml > new file mode 100644 > index 000000000000..65e42258717c > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hardkernel Odroid Go Ultra poweroff > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +description: > + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff > + to its two PMICs in order, this represents the poweroff scheme needed to complete > + a clean poeroff of the system. You don't really need a node for this. Test against the top level compatible and then find the PMIC nodes by their compatible strings. > + > +properties: > + compatible: > + const: hardkernel,odroid-go-ultra-poweroff > + > + hardkernel,rk817-pmic: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the RK817 PMIC node > + > + hardkernel,rk818-pmic: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the RK818 PMIC node > + > +required: > + - compatible > + - hardkernel,rk817-pmic > + - hardkernel,rk818-pmic > + > +additionalProperties: false > + > +examples: > + - | > + poweroff { > + compatible = "hardkernel,odroid-go-ultra-poweroff"; > + hardkernel,rk817-pmic = <&rk817>; > + hardkernel,rk818-pmic = <&rk818>; > + }; > > -- > b4 0.10.1 >
Hi, On 02/11/2022 17:23, Rob Herring wrote: > On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote: >> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> to its two PMICs in order, this represents the poweroff scheme needed to complet >> a clean poeroff of the system. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> new file mode 100644 >> index 000000000000..65e42258717c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> @@ -0,0 +1,42 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hardkernel Odroid Go Ultra poweroff >> + >> +maintainers: >> + - Neil Armstrong <neil.armstrong@linaro.org> >> + >> +description: >> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> + to its two PMICs in order, this represents the poweroff scheme needed to complete >> + a clean poeroff of the system. > > You don't really need a node for this. Test against the top level > compatible and then find the PMIC nodes by their compatible strings. Hmm ok, indeed would be simpler. Neil > >> + >> +properties: >> + compatible: >> + const: hardkernel,odroid-go-ultra-poweroff >> + >> + hardkernel,rk817-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK817 PMIC node >> + >> + hardkernel,rk818-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK818 PMIC node >> + >> +required: >> + - compatible >> + - hardkernel,rk817-pmic >> + - hardkernel,rk818-pmic >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + poweroff { >> + compatible = "hardkernel,odroid-go-ultra-poweroff"; >> + hardkernel,rk817-pmic = <&rk817>; >> + hardkernel,rk818-pmic = <&rk818>; >> + }; >> >> -- >> b4 0.10.1 >>
diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml new file mode 100644 index 000000000000..65e42258717c --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Hardkernel Odroid Go Ultra poweroff + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +description: + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff + to its two PMICs in order, this represents the poweroff scheme needed to complete + a clean poeroff of the system. + +properties: + compatible: + const: hardkernel,odroid-go-ultra-poweroff + + hardkernel,rk817-pmic: + $ref: /schemas/types.yaml#/definitions/phandle + description: Phandle to the RK817 PMIC node + + hardkernel,rk818-pmic: + $ref: /schemas/types.yaml#/definitions/phandle + description: Phandle to the RK818 PMIC node + +required: + - compatible + - hardkernel,rk817-pmic + - hardkernel,rk818-pmic + +additionalProperties: false + +examples: + - | + poweroff { + compatible = "hardkernel,odroid-go-ultra-poweroff"; + hardkernel,rk817-pmic = <&rk817>; + hardkernel,rk818-pmic = <&rk818>; + };
The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff to its two PMICs in order, this represents the poweroff scheme needed to complet a clean poeroff of the system. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+)