From patchwork Wed Nov 2 18:08:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13028758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C39CFC4332F for ; Wed, 2 Nov 2022 18:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iOZTXHiTHzvryEOBNWlqKxWMgXp4buj6k0Llalbqm0g=; b=3/hZwGWYhhekpi 5xHfANFlsETB6Jh/mkyYRE/PDhOWpoZ8/jIXe1PJyiKnm8kq8DFGNf64AM9MklGmjzhR6xJcvj3yr i0E077yl9I5dOsqBDOkT5nFVjVdrmpXMRKe+QuM+3w3RDXugAsZ75A9IUbe0j61eEwEnx0QasRd+W tQv87bf1atk0Bh04jMfqvNjdyT9rpCtZFH7iAawZLGNthpwJBuW7TEJESHH0+ugdBZ7B06WhKMg1a 0wbgqG9PqWvBJt7MjXvbok9LCNSiNHvddw3dV2aEstN5kzSFlKGN/zbRQ8xWi9H8jxp6XGysLv/A7 BP2eqxe+v0LQ+pje3SHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqICl-00CqgR-03; Wed, 02 Nov 2022 18:11:11 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqIA0-00Coe6-Va for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 18:08:24 +0000 Received: by mail-ej1-x635.google.com with SMTP id ud5so47512290ejc.4 for ; Wed, 02 Nov 2022 11:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3bJiWx1wliVbcBA4hLVtU2HKADrW2hjL3FgeqkhgWtw=; b=MuOr6WgUNRTbGp0fKCLMkl/k7dGETn0MCPk6OvhPg3lmMvlQgmcuBFQ+ABDIQVEfIR wFZp5SWC4EFvbN0KmunKKO77/O/BC7U/qywpY2f1LZBtchRftfHVF3XlxDQXgmGoQ3Cu HRfmoLIhb4dl4QLwwj8v/orGggqh47FggbluTDhATnJPTKIyLEFUq6U5YhVS+2MCTQVG Gk2wEwdsPhpcbyRz3cEpnHhdYsYto1gGKo/qcRpNS7dSxQpynS9SIQ1g/wDHuap9qgst EArzOONtTazMJBiM1MR40HcTRdRrPXfFh+vXs2vu6s+5u1L8ble5iN+quusR0rM+WQoX JcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3bJiWx1wliVbcBA4hLVtU2HKADrW2hjL3FgeqkhgWtw=; b=YXLHJN4CrSmfQrBVQ3dV13NMGdLWZXSGwj+ZYeWIBNmjCljThI/Me1mzZiWg/t9NGc khKgA3nDb0f7/QkNZI0IYyuFdKwbOOJ7/RhT3tyiSzwX2Qei1o0c/9C7IkAnnCIS469f 1hxCFGK8dndUzAYochmdB8f8pOQYXaBHgR+RYqd6+rQQAkPw/V028rn74oUSUifeaupi RbsS45wtSd8TKZVJwq4VoXFgOlnFpa7Akx9pWiVrwDH+glAjUvsrIeDzyswzq+ReeTie gKWWxHEfb2QmBdydHan8088FaJ5wr7qGWvJnIf7dCU4sN2XE5xgOt/SAvgMA0cWHgN52 x4vQ== X-Gm-Message-State: ACrzQf3enRqAU/u938MVBnt9biiYmgttM1pncrH3xk8N37Uc7CB0nUjp s/VN9NlHDXMftWbCK+SHQLE= X-Google-Smtp-Source: AMsMyM4280G5nDkbI8u023cMcU5BlS9r2WOVAAA+6//bk1OD+H9jRtahZ1KPvN75QhuxsNTEmyAj5Q== X-Received: by 2002:a17:907:b15:b0:7a7:19a3:e9e7 with SMTP id h21-20020a1709070b1500b007a719a3e9e7mr24606410ejl.361.1667412498590; Wed, 02 Nov 2022 11:08:18 -0700 (PDT) Received: from kista.localdomain (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id gy8-20020a170906f24800b007317f017e64sm5677460ejb.134.2022.11.02.11.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 11:08:18 -0700 (PDT) From: Jernej Skrabec To: mripard@kernel.org, paul.kocialkowski@bootlin.com Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH v2 01/11] media: cedrus: remove superfluous call Date: Wed, 2 Nov 2022 19:08:00 +0100 Message-Id: <20221102180810.267252-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102180810.267252-1-jernej.skrabec@gmail.com> References: <20221102180810.267252-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_110821_061351_1EC494F7 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cedrus_try_fmt_vid_out() is called two times inside cedrus_s_fmt_vid_out(), but nothing changes between calls which would influence output format. Remove first call, which was added later. Acked-by: Paul Kocialkowski Signed-off-by: Jernej Skrabec --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index 33726175d980..1c3c1d080d31 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c @@ -309,10 +309,6 @@ static int cedrus_s_fmt_vid_out(struct file *file, void *priv, struct vb2_queue *peer_vq; int ret; - ret = cedrus_try_fmt_vid_out(file, priv, f); - if (ret) - return ret; - vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type); /* * In order to support dynamic resolution change,