From patchwork Fri Nov 4 17:04:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13032365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A0D4C433FE for ; Fri, 4 Nov 2022 17:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1CEYnYG5D1txnL5nFw89+YiAByefFxSExTp7ctBCJ6M=; b=IzTxHmTSnOxYnp FKksQFAoOscPjBe9fRP53Ll5X1UvaAxTjBXLPLSdvAorvsUNURQSv9fphJ3fpxhulGR1ZMVLVyfok bj8MHG8BHDwgaXlOW/dh9vfCXTD2RkzqXE9nP5YqVTQld+GheIF5FX+ZbAcatt5oUIMoijNqvDpaP fSQjAqHvixbaarWKtLbDvSbsPwqVL/ApEDxzIaCfTotXjKxdIXPDkGEp4LPfShf/03ea9KpHmUEsE d2Z17+9j5Q2So+tq59DQhSPE3hiGnfgKAkMFMWBnyg0ry1m1TsFaqleuoOfwS696oTl33mZZOqjgq bWwzRhQRnY/limauq5DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or07k-004amG-DN; Fri, 04 Nov 2022 17:04:56 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or07R-004ajr-Ho for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 17:04:40 +0000 Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7799E85045; Fri, 4 Nov 2022 18:04:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667581471; bh=0ufUAIKGB6SLx2RNSpHBG4ZxSPKRl5BxwyxjCEvpJpw=; h=From:To:Cc:Subject:Date:From; b=Y7gVM1ynUJAHOF6kMyuzYNwqkWC/mU6sLisL2RmZs3iq9G+bUFLIjXBnzciUb6ZYH AkfsPwYvb44UFTa6KbJ0M9A4dcojZRGlvkAjxsAG7mwCI1caDFx+5vKmgoWjPrMsSt 9O87Casy3fIPjkPw9hqahKJCj0vHZ4OXMXLO/IFlZqeMNvSIFWeqS7GVREH8QC9gt2 2Z9YNkA/QWnUD6Ydv7gQfPskMp+TJ1TsrqXdocZf+QKQ1RzZPSvD8HA7nyxOmBO+kH FG+SqSC24NZzb5QjxA4XRwXwM46khG+ZmH5TJzG5AgpPD0AlrVGkZQydTY/eAw+OMd sOpNW3w7oDjJA== From: Marek Vasut To: devicetree@vger.kernel.org Cc: Marek Vasut , Alexander Stein , Fabio Estevam , Krzysztof Kozlowski , Lucas Stach , Richard Zhu , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team Subject: [RFC][PATCH v3 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations Date: Fri, 4 Nov 2022 18:04:15 +0100 Message-Id: <20221104170417.232132-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_100438_011971_D83667E3 X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The i.MX SoCs have various clock configurations routed into the PCIe IP, the list of clock is below. Document all those configurations in the DT binding document. All SoCs: pcie, pcie_bus 6QDL, 7D: + pcie_phy 6SX: + pcie_phy pcie_inbound_axi 8MQ: + pcie_phy pcie_aux 8MM, 8MP: + pcie_aux Acked-by: Alexander Stein Signed-off-by: Marek Vasut --- Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc: Lucas Stach Cc: Richard Zhu Cc: Rob Herring Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team To: devicetree@vger.kernel.org --- V2: - Add AB from Alex V3: - Duplicate clock-names maxItems to mx6sx and mx8mq compatibles - Flatten the if-else structure - The validation no longer works and introduces errors like these: arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb: pcie@33800000: clock-names:2: 'pcie_phy' was expected --- .../bindings/pci/fsl,imx6q-pcie.yaml | 55 +++++++++++++++++-- 1 file changed, 50 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 376e739bcad40..44c65d3ec07b9 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -14,9 +14,6 @@ description: |+ This PCIe host controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in snps,dw-pcie.yaml. -allOf: - - $ref: /schemas/pci/snps,dw-pcie.yaml# - properties: compatible: enum: @@ -56,12 +53,10 @@ properties: imx8mq-pcie. clock-names: - minItems: 3 items: - const: pcie - const: pcie_bus - const: pcie_phy - - const: pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie num-lanes: const: 1 @@ -177,6 +172,56 @@ required: unevaluatedProperties: false +allOf: + - $ref: /schemas/pci/snps,dw-pcie.yaml# + + - if: + properties: + compatible: + contains: + const: fsl,imx6sx-pcie + then: + properties: + clocks: + minItems: 4 + clock-names: + items: + - const: pcie + - const: pcie_bus + - const: pcie_phy + - const: pcie_inbound_axi + + - if: + properties: + compatible: + contains: + const: fsl,imx8mq-pcie + then: + properties: + clocks: + minItems: 4 + clock-names: + items: + - const: pcie + - const: pcie_bus + - const: pcie_phy + - const: pcie_aux + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mm-pcie + - fsl,imx8mp-pcie + then: + properties: + clock-names: + items: + - const: pcie + - const: pcie_bus + - const: pcie_aux + examples: - | #include