From patchwork Fri Nov 4 17:04:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13032366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C576EC4332F for ; Fri, 4 Nov 2022 17:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jltc6DMqB9al4E3aSBKcVRyQqGw6+n9os/v4fRYuPXI=; b=MX4CBr/TnG5rXv EX0h7ApsqC1IIEvN8/hRyaJShZMRtDu5h1rQGU/lk/LhGvTWOcbFNIC8dossbn15htoZhKxm+b39O /70FWbsUV4Zg+CQGtgd2Hjnww6KD3W2TmhMYCwRxKWkNvSTd3zpXfrq6eg++3VeynTLdyq8Wam2P1 J7GLagT644F5yTqOIGal2W5gYrqRtAXucGg+7uTKW1gBcgVm4Q4v0Kb1X8sctg96/xr7LLpvuXbQy k7lv5mNoQsgQO/L+QuqAn4xsB0WxcOBZmgeDDAxtxfGSscuk0XhC9hkWbkc+UASK/sDN6B6VOqh0i 00bXi2VccFXFNqMNo1/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or07V-004al8-0T; Fri, 04 Nov 2022 17:04:41 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or07R-004ajt-Hp for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 17:04:39 +0000 Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 409378511D; Fri, 4 Nov 2022 18:04:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667581472; bh=oRSfJ+CFmuIkU4hdVYo3jr2kK1Z2N8/mcWrd9UAcLAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sTw3JIiBN3q+EXfQWkrZAe2NcaD5G3b+MpyRbbNAvW/lh87rnV7H/Quzbz5NuoVLF WGuups0aYUhPpS4B3wQITOvBuPFpXZ8QZEeRCCKRn+zOM1tT9E/Bd28ItO6qmccBfd EPWjRnecEQikhxzsNBsdMXKp95B8/+HZhUTZGN9+7ya8ix/Oddda7Xe1KGuOWxQYdy FrFA8ir+Qfv9CES3QHAtVFKA9618LDIqy74UnEwwzGh54E2V6uweo0Iv5vEPahu/mR blKO5sT+z63VJKDU9mS/IuESmFHRdT0HUDY9pZAKqKwFBlfMjYa6Qq43p1ledwFiLD ChI1fO+bBSiOA== From: Marek Vasut To: devicetree@vger.kernel.org Cc: Marek Vasut , Fabio Estevam , Krzysztof Kozlowski , Lucas Stach , Richard Zhu , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team Subject: [RFC][PATCH v3 3/3] dt-bindings: imx6q-pcie: Handle more resets on legacy platforms Date: Fri, 4 Nov 2022 18:04:17 +0100 Message-Id: <20221104170417.232132-3-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221104170417.232132-1-marex@denx.de> References: <20221104170417.232132-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_100438_009489_703CCF4B X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The i.MX6 and i.MX7D does not use block controller to toggle PCIe reset, hence the PCIe DT description contains three reset entries on these older SoCs. Add this exception into the binding document. Signed-off-by: Marek Vasut --- Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc: Lucas Stach Cc: Richard Zhu Cc: Rob Herring Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team To: devicetree@vger.kernel.org --- V2: - Add mx8mq to 3-reset PCIe core variant - Handle the resets in allOf section V3: - Reinstate reset: maxItems:3 and add minItems:2 - Move reset-names back to main section - The validation no longer works and introduces errors like these: arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb: pcie@33800000: reset-names:0: 'pciephy' was expected --- .../bindings/pci/fsl,imx6q-pcie.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 5d731aca34b4d..44a1404cbc2c0 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -80,11 +80,13 @@ properties: - const: pcie_phy resets: + minItems: 2 maxItems: 3 description: Phandles to PCIe-related reset lines exposed by SRC IP block. Additional required by imx7d-pcie and imx8mq-pcie. reset-names: + minItems: 2 items: - const: pciephy - const: apps @@ -251,6 +253,29 @@ allOf: maxItems: 1 power-domain-names: false + - if: + properties: + compatible: + contains: + enum: + - fsl,imx6q-pcie + - fsl,imx6sx-pcie + - fsl,imx6qp-pcie + - fsl,imx7d-pcie + - fsl,imx8mq-pcie + then: + properties: + reset-names: + maxItems: 3 + else: + properties: + resets: + maxItems: 2 + reset-names: + items: + - const: apps + - const: turnoff + examples: - | #include