diff mbox series

[v2,2/4] clk: at91: rm9200: fix usb device clock id

Message ID 20221104215516.2874922-3-m.grzeschik@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series ARM: at91: USB Device Port fixes | expand

Commit Message

Michael Grzeschik Nov. 4, 2022, 9:55 p.m. UTC 
Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
"Enables the automatic disable of the Master Clock of the USB Device
Port when a suspend condition occurs". We fix the index to the real UDP
id which "Enables the 48 MHz clock of the USB Device Port".

Cc: mturquette@baylibre.com
Cc: sboyd@kernel.org
Cc: nicolas.ferre@microchip.com
Cc: alexandre.belloni@bootlin.com
Cc: ludovic.desroches@microchip.com
Cc: claudiu.beznea@microchip.com
Cc: linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: kernel@pengutronix.de
Fixes: 02ff48e4d7f7 (clk: at91: add at91rm9200 pmc driver)
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

---
v1 -> v2: - removed ; from patch description
          - added fixes tag

 drivers/clk/at91/at91rm9200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Claudiu Beznea Nov. 9, 2022, 11:57 a.m. UTC | #1 
On 04.11.2022 23:55, Michael Grzeschik wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
> "Enables the automatic disable of the Master Clock of the USB Device
> Port when a suspend condition occurs". We fix the index to the real UDP
> id which "Enables the 48 MHz clock of the USB Device Port".
> 
> Cc: mturquette@baylibre.com
> Cc: sboyd@kernel.org
> Cc: nicolas.ferre@microchip.com
> Cc: alexandre.belloni@bootlin.com
> Cc: ludovic.desroches@microchip.com
> Cc: claudiu.beznea@microchip.com
> Cc: linux-clk@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: kernel@pengutronix.de
> Fixes: 02ff48e4d7f7 (clk: at91: add at91rm9200 pmc driver)

Fixes tag should be in format:

<sha-id> ("commit description")

> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> 
> ---
> v1 -> v2: - removed ; from patch description
>           - added fixes tag
> 
>  drivers/clk/at91/at91rm9200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
> index b174f727a8ef8d..16870943a13e54 100644
> --- a/drivers/clk/at91/at91rm9200.c
> +++ b/drivers/clk/at91/at91rm9200.c
> @@ -40,7 +40,7 @@ static const struct clk_pll_characteristics rm9200_pll_characteristics = {
>  };
> 
>  static const struct sck at91rm9200_systemck[] = {
> -       { .n = "udpck", .p = "usbck",    .id = 2 },
> +       { .n = "udpck", .p = "usbck",    .id = 1 },
>         { .n = "uhpck", .p = "usbck",    .id = 4 },
>         { .n = "pck0",  .p = "prog0",    .id = 8 },
>         { .n = "pck1",  .p = "prog1",    .id = 9 },
> --
> 2.30.2
>
diff mbox series

Patch

diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
index b174f727a8ef8d..16870943a13e54 100644
--- a/drivers/clk/at91/at91rm9200.c
+++ b/drivers/clk/at91/at91rm9200.c
@@ -40,7 +40,7 @@  static const struct clk_pll_characteristics rm9200_pll_characteristics = {
 };
 
 static const struct sck at91rm9200_systemck[] = {
-	{ .n = "udpck", .p = "usbck",    .id = 2 },
+	{ .n = "udpck", .p = "usbck",    .id = 1 },
 	{ .n = "uhpck", .p = "usbck",    .id = 4 },
 	{ .n = "pck0",  .p = "prog0",    .id = 8 },
 	{ .n = "pck1",  .p = "prog1",    .id = 9 },