| Message ID | 20221107005433.11079-3-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: suniv: F1C100s: add more peripherals | expand |
Dne ponedeljek, 07. november 2022 ob 01:54:25 CET je Andre Przywara napisal(a): > The Allwinner F1C100s family of SoCs contain a PWM controller compatible > to the one used in the A20 chip. > Add the DT node so that any users can simply enable it in their board > DT. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
On Mon, Nov 07, 2022 at 12:54:25AM +0000, Andre Przywara wrote: > The Allwinner F1C100s family of SoCs contain a PWM controller compatible > to the one used in the A20 chip. > Add the DT node so that any users can simply enable it in their board > DT. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> I checked "by hand" that this matches the modified binding in patch 01/10. Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> I assume the whole series will go in via a tree different from the PWM tree? While this is Thierry's area of maintenance, I'd be surprised if he had concerns about that. Best regards Uwe
On Tue, Nov 15, 2022 at 11:19:26AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 07, 2022 at 12:54:25AM +0000, Andre Przywara wrote: > > The Allwinner F1C100s family of SoCs contain a PWM controller compatible > > to the one used in the A20 chip. > > Add the DT node so that any users can simply enable it in their board > > DT. > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > I checked "by hand" that this matches the modified binding in patch > 01/10. > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > I assume the whole series will go in via a tree different from the PWM > tree? While this is Thierry's area of maintenance, I'd be surprised if > he had concerns about that. Yeah, it's probably best for the Allwinner maintainers to pick this up into their tree so that the bindings changes go along with the DT changes. Acked-by: Thierry Reding <thierry.reding@gmail.com>
Dne torek, 15. november 2022 ob 11:25:12 CET je Thierry Reding napisal(a): > On Tue, Nov 15, 2022 at 11:19:26AM +0100, Uwe Kleine-König wrote: > > On Mon, Nov 07, 2022 at 12:54:25AM +0000, Andre Przywara wrote: > > > The Allwinner F1C100s family of SoCs contain a PWM controller compatible > > > to the one used in the A20 chip. > > > Add the DT node so that any users can simply enable it in their board > > > DT. > > > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > > > I checked "by hand" that this matches the modified binding in patch > > 01/10. > > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > I assume the whole series will go in via a tree different from the PWM > > tree? While this is Thierry's area of maintenance, I'd be surprised if > > he had concerns about that. > > Yeah, it's probably best for the Allwinner maintainers to pick this up > into their tree so that the bindings changes go along with the DT > changes. Yeah, that's the plan. I'll merge it in following days. Best regards, Jernej > > Acked-by: Thierry Reding <thierry.reding@gmail.com>
diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi b/arch/arm/boot/dts/suniv-f1c100s.dtsi index a01541ba42c5..81749d5da12f 100644 --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi @@ -218,6 +218,15 @@ wdt: watchdog@1c20ca0 { clocks = <&osc32k>; }; + pwm: pwm@1c21000 { + compatible = "allwinner,suniv-f1c100s-pwm", + "allwinner,sun7i-a20-pwm"; + reg = <0x01c21000 0x400>; + clocks = <&osc24M>; + #pwm-cells = <3>; + status = "disabled"; + }; + uart0: serial@1c25000 { compatible = "snps,dw-apb-uart"; reg = <0x01c25000 0x400>;
The Allwinner F1C100s family of SoCs contain a PWM controller compatible to the one used in the A20 chip. Add the DT node so that any users can simply enable it in their board DT. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm/boot/dts/suniv-f1c100s.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)