From patchwork Mon Nov 7 06:21:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xiujianfeng X-Patchwork-Id: 13033824 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15075C433FE for ; Mon, 7 Nov 2022 06:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2eOBK01DanJg7EkYp10qbO4C7drk5Fuz7b8qSj4zRPk=; b=e/KkoFkWri2PIA q/jWssNyO4Fyk2y/kl0WFsFtbTdATO049slPQTYfPTNXfd2uMqPf8YwpBv3/FMDWoKctmLYRHirdE vAglJuXX8KnabFRFNk+LZVv+YxS0cMac2+VpOWdQUZOQW9YNiP52sUBdHQpiC99OsRgNbBnsks24Z 7i3s1eHuwsXPqWSrMg96B8T2aDGAOsEB1c+tWEBW4CJJMxuaZ+ocHVOz0RRlTLC/kmMPLMecylYWu RhCmD15fsx5BqxvSt+fLb7rJM8OGGAqykD4qFDiBf7m4DohhOOYNOyLmQnkp2IheQbTH+eUmDXV31 RJsJAe+MpFppP2teiVCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orvYw-00C72m-5G; Mon, 07 Nov 2022 06:24:50 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orvYr-00C71v-S6 for linux-arm-kernel@lists.infradead.org; Mon, 07 Nov 2022 06:24:48 +0000 Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N5LmW53LHzRp42; Mon, 7 Nov 2022 14:24:27 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 14:24:33 +0800 From: Xiu Jianfeng To: , , , , CC: , , , Subject: [PATCH] tty: serial: samsung_tty: Fix clk resource leak issue Date: Mon, 7 Nov 2022 14:21:20 +0800 Message-ID: <20221107062120.20321-1-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_222446_096377_D94038C5 X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the s3c24xx_serial_get_options(), calling clk_get() without clk_put() will cause clk resource leak issue, this patch fixes it. Fixes: b497549a035c ("[ARM] S3C24XX: Split serial driver into core and per-cpu drivers") Signed-off-by: Xiu Jianfeng --- drivers/tty/serial/samsung_tty.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 77d1363029f5..8a3bb9832172 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2529,9 +2529,10 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, sprintf(clk_name, "clk_uart_baud%d", clk_sel); clk = clk_get(port->dev, clk_name); - if (!IS_ERR(clk)) + if (!IS_ERR(clk)) { rate = clk_get_rate(clk); - else + clk_put(clk); + } else rate = 1; *baud = rate / (16 * (ubrdiv + 1));