From patchwork Sun Nov 13 18:07:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13041688 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5400DC433FE for ; Sun, 13 Nov 2022 18:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pzC1Dv0wuHdNCEd6PW+kdNzGmEdjMWC2JKs73uNyqRI=; b=e50gEQgKr0olwA dezAzFkUFhZOa4e8zwR0Dp0IoSlN98iof4wRwugXI2X7pJa61VyOrmC/NA8eokXIamPH6pfooqm/H CMvfXi8fekOMSBab+PT4qQvw4+9poQvDH7GcMbD6I3JgxIIYdJQGoicK7qIbSzvTfOPCUR1SfhHZ6 4VyvTOwJOwkWgf2HCudfjm0zNSR8mTxs49iSpnvJIoY/MmlARGXQZ5hZZPCunKbw6fGhQxcN/M6bl V7yvUlpajBHrmv31JxS+9/VJfn/5o9uC7tlkLo0CDYPDjNCBN6CzVSUExg/H1FRgTB3TVNS3K327T boucbiNjA+vYJ1G3QiEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouHOS-00CpTC-Kp; Sun, 13 Nov 2022 18:07:44 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouHO6-00CpH2-GL for linux-arm-kernel@lists.infradead.org; Sun, 13 Nov 2022 18:07:23 +0000 Received: by mail-ej1-x62a.google.com with SMTP id y14so23378053ejd.9 for ; Sun, 13 Nov 2022 10:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i9rY57aH7I24rE4lreigisIrtzpJlcbzkFokeDM/SUE=; b=pFemdqI3NCKH94vulxhf/vdZTI0Gvuta3r5dUkx3e55XLXOzWd/aFw+aDTHduuYbna D7BGe6sBzXKmd4iwIKdux2WoUg1Bjq9ernlR9knxV8NDbuNhKOxanKETi3KFW0n47gKn MUH2G9SO+q0qZQES6vIbNXsL61weGlblneq9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i9rY57aH7I24rE4lreigisIrtzpJlcbzkFokeDM/SUE=; b=mYT/j8f2/PN0Z0/9YYn9WA+EaSsuqawMGf1QMjGuAlMa5QWXV01oc2LC9CTZnDiuVC zZ1fj/wNe4gkc0kE75tzx6ouWNpOEFl3XT72NW4DgK06vr7ID5kuYc7iWbBZJqRcT/p9 Lw8qAgHeZxi/+R16IPxeosFUfvmFzzOLiduIgjvGJJuxHqEjjtT+Rywm39Jo7zUsQh6b WhwMIkwYTYyhcPaRPRvF8mn/JjZN/TL51qpdYPfvja+ModoA37+Dukrf/fuDKxXfS2m0 9HQhzUS7V475xZe3sXN+fTWQm3xq9oIt7Uj0cdTur7cFE/vNYAliGzRvv6Kz7HzHFvJf o+/Q== X-Gm-Message-State: ANoB5plHGQlWMZmd3B8mTAFxF9ec/DgQCZGhcDFMHJykfK1NztMA/imY M1ukkKe+nF8pjNeZ/7zLii7Vrg== X-Google-Smtp-Source: AA0mqf7vU9UIfEsVBc/Fj5hCTFltlolOM4D2/M7vGpRB1YWsvBd/7QuxskC3Up4KGH3U5JiK9ZUd1A== X-Received: by 2002:a17:907:9d03:b0:7ae:87ef:d9a6 with SMTP id kt3-20020a1709079d0300b007ae87efd9a6mr8139536ejc.397.1668362839685; Sun, 13 Nov 2022 10:07:19 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-40-103-33.business.telecomitalia.it. [79.40.103.33]) by smtp.gmail.com with ESMTPSA id n11-20020a170906118b00b007a8de84ce36sm3171058eja.206.2022.11.13.10.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 10:07:19 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, michael@amarulasolutions.com, Dario Binacchi , Abel Vesa , Anson Huang , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH 2/5] clk: imx: replace osc_hdmi with dummy Date: Sun, 13 Nov 2022 19:07:07 +0100 Message-Id: <20221113180710.1625410-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221113180710.1625410-1-dario.binacchi@amarulasolutions.com> References: <20221113180710.1625410-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_100722_563721_5FCFEAE1 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no occurrence of the hdmi oscillator in the reference manual (document IMX8MNRM Rev 2, 07/2022). Further, if we consider the indexes 76-81 and 134 of the "Clock Root" table of chapter 5 of the RM, there is no entry for the source select bits 101b, which is the setting referenced by "osc_hdmi". Fix by renaming "osc_hdmi" with "dummy", a clock which has already been used for missing source select bits. Tested on the BSH SystemMaster (SMM) S2 board. Fixes: 96d6392b54dbb ("clk: imx: Add support for i.MX8MN clock driver") Signed-off-by: Dario Binacchi --- drivers/clk/imx/clk-imx8mn.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index 72f9563a0ff6..0fae97e61e2c 100644 --- a/drivers/clk/imx/clk-imx8mn.c +++ b/drivers/clk/imx/clk-imx8mn.c @@ -108,27 +108,27 @@ static const char * const imx8mn_disp_pixel_sels[] = {"osc_24m", "video_pll1_out "sys_pll3_out", "clk_ext4", }; static const char * const imx8mn_sai2_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai3_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai5_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext2", "clk_ext3", }; static const char * const imx8mn_sai6_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai7_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_spdif1_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext2", "clk_ext3", }; static const char * const imx8mn_enet_ref_sels[] = {"osc_24m", "sys_pll2_125m", "sys_pll2_50m",