From patchwork Mon Nov 14 01:57:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 13041815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE878C4332F for ; Mon, 14 Nov 2022 01:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5tF1GuxEgMk4z8mLx6YVVlN6VqT4ZLiHLjpv4HXC/Qk=; b=1Lk2CsoC6Rj6/g +sflX5CvJ8pOEcdlMqSpQTz0CArX03O1C1gdzc6dQlyMBB+ODnk+VIOk1mxa5cjA2Uh5rjncYVb03 M7wOe4WxHsHm+VtgAAslHKz4ndT5lr02MrXX5MrEQMiuRwTMPOJTOlOeCStaDDQQvfZwD3aZtimQR do1aJHJ2UFlAGOgaDBMedUUy8doWIRlh3kTqasoFanN9xcoP+LRiielKlJFGqFDRqqiJVpoOniTyI v0qLNGz1pgAdMJIHDgQd7UGUJieSN4+vy3/CG+7q16mD0eV4d2UadKmdvkw7TdPGAv6puoKF8wgW6 ThW1b8A+gWdvbXiwEI2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouOjo-00FUQg-6d; Mon, 14 Nov 2022 01:58:16 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouOjc-00FUM6-4G for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 01:58:06 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 982523200913; Sun, 13 Nov 2022 20:57:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 13 Nov 2022 20:57:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1668391073; x=1668477473; bh=E9 uIAIxUjiZh/NqdAFhxdQQd6pb0o+DNnALIZuHYHOs=; b=OfbZpT/d/nCucpY8If Ivz1X1vBDXH5hM0CnqfATv4F0RBYtu3ri+xhPjSNzqa6EVAS74FI5DGhJUnMeZtB prKBAR2MBPoqmVT0h+90mRc+Mu1HCp7lo+S4WWyP3Hhse8FXmWl0ZhSxLd1xiygS Kcw6lsupErjYf9B3lEZoF3wekUSWiO+qdPwoEPUzOxC/jaQPviZXpjIxJ3F3MBVl qdt0892WkXxgGonzlOIezXS6MtB5Na6rdMy4MhL7yPDRlkvEiPGNVeDOHoMbTDuR 43nLOPeS35A0oGcRhmY41jC5xCHygNqBuNOkZllpLGoiRWg/H1UrWsvyqqkqHMEw 9oCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668391073; x=1668477473; bh=E9uIAIxUjiZh/ NqdAFhxdQQd6pb0o+DNnALIZuHYHOs=; b=tKxDvCrOnkcyDpWUGhUNVe+DjapTA +CI67IjdnEL+FPgyZ+uw3EbJFtY/pOT+MinYhI+WcRatng9gUZE7vlKnux+wQ7Hs AbQy5u1cGG0s5lJ5ktUzKTYfDwgwaEJ7VUF0A0kLzCELBiZ2vNJVln3lnCRBfvn/ 5gJHzsxRzy86xshLtvXABOHKe0+VIe2NAMJU/VeMDwTFEj0PYYjbDvKo00M8o2tG Gof4nKZvZUn78y6SNqlcN/hRAUai/4lkRSIzQ2fk2TB3W6yt6anWZR5MRbO3DVqj mONBzyqyHlkLr8gIDvi6SUaxwCXBnPBvzaJpXnZRE0Mgc7WJJkfPHksuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedugdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeehgfdu feeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Nov 2022 20:57:52 -0500 (EST) From: Samuel Holland To: Chen-Yu Tsai , Jernej Skrabec Cc: Ivaylo Dimitrov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara , Samuel Holland Subject: [PATCH v3 1/3] bus: sunxi-rsb: Remove the shutdown callback Date: Sun, 13 Nov 2022 19:57:47 -0600 Message-Id: <20221114015749.28490-2-samuel@sholland.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221114015749.28490-1-samuel@sholland.org> References: <20221114015749.28490-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_175804_251420_76DF6081 X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Shutting down the RSB controller prevents communicating with a PMIC inside pm_power_off(), since that gets called after device_shutdown(), so it breaks system poweroff on some boards. Reported-by: Ivaylo Dimitrov Tested-by: Ivaylo Dimitrov Acked-by: Jernej Skrabec Fixes: 843107498f91 ("bus: sunxi-rsb: Implement suspend/resume/shutdown callbacks") Signed-off-by: Samuel Holland --- Changes in v3: - Adjust patch 1 commit message drivers/bus/sunxi-rsb.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 4cd2e127946e..17343cd75338 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -812,14 +812,6 @@ static int sunxi_rsb_remove(struct platform_device *pdev) return 0; } -static void sunxi_rsb_shutdown(struct platform_device *pdev) -{ - struct sunxi_rsb *rsb = platform_get_drvdata(pdev); - - pm_runtime_disable(&pdev->dev); - sunxi_rsb_hw_exit(rsb); -} - static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { SET_RUNTIME_PM_OPS(sunxi_rsb_runtime_suspend, sunxi_rsb_runtime_resume, NULL) @@ -835,7 +827,6 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); static struct platform_driver sunxi_rsb_driver = { .probe = sunxi_rsb_probe, .remove = sunxi_rsb_remove, - .shutdown = sunxi_rsb_shutdown, .driver = { .name = RSB_CTRL_NAME, .of_match_table = sunxi_rsb_of_match_table,