| Message ID | 20221114054655.68090-4-aakarsh.jain@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/3] media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250 SoC | expand |
On 14/11/2022 06:46, Aakarsh Jain wrote: > commit "752d3a23d1f68de87e3c" which adds MFC codec device node Please run scripts/checkpatch.pl and fix reported warnings. > for exynos3250 SoC. Since exynos3250.dtsi and exynos5420.dtsi are > using same compatible string as "samsung,mfc-v7" but their node > properties are different. As both SoCs have MFC v7 hardware module > but with different clock hierarchy and complexity. > Add new compatible string followed by mfc-v7 fallback for Exynos3250 > SoC. > > Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > Suggested-by: Alim Akhtar <alim.akhtar@samsung.com> > Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 326b9e0ed8d3..1a29993fca0b 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -485,7 +485,7 @@ > }; > > mfc: codec@13400000 { > - compatible = "samsung,mfc-v7"; > + compatible = "samsung,exynos3250-mfc","samsung,mfc-v7"; Missing space. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 326b9e0ed8d3..1a29993fca0b 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -485,7 +485,7 @@ }; mfc: codec@13400000 { - compatible = "samsung,mfc-v7"; + compatible = "samsung,exynos3250-mfc","samsung,mfc-v7"; reg = <0x13400000 0x10000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; clock-names = "mfc", "sclk_mfc";