diff mbox series

[1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered

Message ID 20221121015451.2471196-2-bero@baylibre.com (mailing list archive)
State New, archived
Headers show
Series Remove the pins-are-numbered DT property | expand

Commit Message

Bernhard Rosenkränzer Nov. 21, 2022, 1:54 a.m. UTC
Remove the check for the unnecessary pins-are-numbered Devicetree property.

Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

AngeloGioacchino Del Regno Nov. 21, 2022, 9 a.m. UTC | #1
Il 21/11/22 02:54, Bernhard Rosenkränzer ha scritto:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Matthias Brugger Nov. 21, 2022, 12:33 p.m. UTC | #2
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 076ae0b38e3d7..553d16703475b 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1057,7 +1057,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
>   	struct pinctrl_pin_desc *pins;
>   	struct mtk_pinctrl *pctl;
>   	struct device_node *np = pdev->dev.of_node, *node;
> -	struct property *prop;
>   	int ret, i;
>   
>   	pctl = devm_kzalloc(&pdev->dev, sizeof(*pctl), GFP_KERNEL);
> @@ -1066,11 +1065,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
>   
>   	platform_set_drvdata(pdev, pctl);
>   
> -	prop = of_find_property(np, "pins-are-numbered", NULL);
> -	if (!prop)
> -		return dev_err_probe(dev, -EINVAL,
> -				     "only support pins-are-numbered format\n");
> -
>   	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
>   	if (node) {
>   		pctl->regmap1 = syscon_node_to_regmap(node);
Krzysztof Kozlowski Nov. 21, 2022, 12:35 p.m. UTC | #3
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

FWIW:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Kevin Hilman Nov. 21, 2022, 6:20 p.m. UTC | #4
Bernhard Rosenkränzer <bero@baylibre.com> writes:

> Remove the check for the unnecessary pins-are-numbered Devicetree property.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>
diff mbox series

Patch

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 076ae0b38e3d7..553d16703475b 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -1057,7 +1057,6 @@  int mtk_pctrl_init(struct platform_device *pdev,
 	struct pinctrl_pin_desc *pins;
 	struct mtk_pinctrl *pctl;
 	struct device_node *np = pdev->dev.of_node, *node;
-	struct property *prop;
 	int ret, i;
 
 	pctl = devm_kzalloc(&pdev->dev, sizeof(*pctl), GFP_KERNEL);
@@ -1066,11 +1065,6 @@  int mtk_pctrl_init(struct platform_device *pdev,
 
 	platform_set_drvdata(pdev, pctl);
 
-	prop = of_find_property(np, "pins-are-numbered", NULL);
-	if (!prop)
-		return dev_err_probe(dev, -EINVAL,
-				     "only support pins-are-numbered format\n");
-
 	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
 	if (node) {
 		pctl->regmap1 = syscon_node_to_regmap(node);