| Message ID | 20221121145114.2362260-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger | expand |
On Mon, Nov 21, 2022 at 11:51:12AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > "none", "phy0tx" and "hci0-power" are not valid values for the > linux,default-trigger property and trigger the following warnings when > running: > > make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml > > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: user-led4:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > 'none' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > 'none' does not match '^mmc[0-9]+$' > 'none' does not match '^cpu[0-9]*$' > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: wlan-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > 'phy0tx' does not match '^mmc[0-9]+$' > 'phy0tx' does not match '^cpu[0-9]*$' > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: bt-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > 'hci0-power' does not match '^mmc[0-9]+$' > 'hci0-power' does not match '^cpu[0-9]*$' > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml > > Remove the invalid linux,default-trigger entries. > Just because the binding is complaining doesn't mean that these triggers are invalid. In this case, the binding needs to be updated as these triggers are supported by the LED subsystem. I tried to do that but somehow didn't follow up: https://lore.kernel.org/lkml/20201210082449.30586-1-manivannan.sadhasivam@linaro.org/ Let me revive that patch. Thanks, Mani > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Fixes: 68ca364d4812 ("arm64: dts: freescale: Add devicetree support for Thor96 board") > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts > index 5d5aa6537225..170e00c2447f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts > @@ -35,7 +35,6 @@ user-led1 { > user-led2 { > label = "green:user2"; > gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "none"; > }; > > user-led3 { > @@ -49,20 +48,17 @@ user-led4 { > label = "green:user4"; > gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>; > panic-indicator; > - linux,default-trigger = "none"; > }; > > wlan-active-led { > label = "yellow:wlan"; > gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "phy0tx"; > default-state = "off"; > }; > > bt-active-led { > label = "blue:bt"; > gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "hci0-power"; > default-state = "off"; > }; > }; > -- > 2.25.1 >
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts index 5d5aa6537225..170e00c2447f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts @@ -35,7 +35,6 @@ user-led1 { user-led2 { label = "green:user2"; gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "none"; }; user-led3 { @@ -49,20 +48,17 @@ user-led4 { label = "green:user4"; gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>; panic-indicator; - linux,default-trigger = "none"; }; wlan-active-led { label = "yellow:wlan"; gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "phy0tx"; default-state = "off"; }; bt-active-led { label = "blue:bt"; gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "hci0-power"; default-state = "off"; }; };