| Message ID | 20221125202008.64595-4-samuel@sholland.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: net: sunxi: Fix binding validation issues | expand |
On Fri, 25 Nov 2022 14:20:08 -0600 Samuel Holland <samuel@sholland.org> wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > index 34a47922296d..4f671478b288 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > @@ -42,6 +42,9 @@ properties: > clock-names: > const: stmmaceth > > + phy-supply: > + description: PHY regulator > + > syscon: > $ref: /schemas/types.yaml#/definitions/phandle > description:
On 25/11/2022 21:20, Samuel Holland wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland <samuel@sholland.org> This looks ok. Best regards, Krzysztof
On Fri, 25 Nov 2022 14:20:08 -0600, Samuel Holland wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml index 34a47922296d..4f671478b288 100644 --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml @@ -42,6 +42,9 @@ properties: clock-names: const: stmmaceth + phy-supply: + description: PHY regulator + syscon: $ref: /schemas/types.yaml#/definitions/phandle description:
This property has always been supported by the Linux driver; see commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the original driver submission includes the phy-supply code but no mention of it in the binding, so the omission appears to be accidental. In addition, the property is documented in the binding for the previous hardware generation, allwinner,sun7i-a20-gmac. Document phy-supply in the binding to fix devicetree validation for the 25+ boards that already use this property. Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ 1 file changed, 3 insertions(+)