| Message ID | 20221204190230.3345590-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ARM: dts: gemini: Push down flash address/size cells | expand |
diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts index 15828ffcae62..138c47e1ac1b 100644 --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts @@ -173,6 +173,8 @@ flash@30000000 { compatible = "cortina,gemini-flash", "jedec-flash"; status = "okay"; reg = <0x30000000 0x00080000>; + #address-cells = <1>; + #size-cells = <1>; /* * This "RedBoot" is the Storlink derivative. diff --git a/arch/arm/boot/dts/gemini-wbd111.dts b/arch/arm/boot/dts/gemini-wbd111.dts index de3c4416b0fb..bfb7fdd589ae 100644 --- a/arch/arm/boot/dts/gemini-wbd111.dts +++ b/arch/arm/boot/dts/gemini-wbd111.dts @@ -86,6 +86,8 @@ flash@30000000 { status = "okay"; /* 8MB of flash */ reg = <0x30000000 0x00800000>; + #address-cells = <1>; + #size-cells = <1>; partition@0 { label = "RedBoot"; diff --git a/arch/arm/boot/dts/gemini-wbd222.dts b/arch/arm/boot/dts/gemini-wbd222.dts index e5ceaadbcc1a..82a08e359198 100644 --- a/arch/arm/boot/dts/gemini-wbd222.dts +++ b/arch/arm/boot/dts/gemini-wbd222.dts @@ -90,6 +90,8 @@ flash@30000000 { status = "okay"; /* 8MB of flash */ reg = <0x30000000 0x00800000>; + #address-cells = <1>; + #size-cells = <1>; partition@0 { label = "RedBoot"; diff --git a/arch/arm/boot/dts/gemini.dtsi b/arch/arm/boot/dts/gemini.dtsi index 04ff38b61986..df24c7416ba9 100644 --- a/arch/arm/boot/dts/gemini.dtsi +++ b/arch/arm/boot/dts/gemini.dtsi @@ -22,8 +22,6 @@ flash: flash@30000000 { pinctrl-names = "default"; pinctrl-0 = <&pflash_default_pins>; bank-width = <2>; - #address-cells = <1>; - #size-cells = <1>; status = "disabled"; };
The platforms not defining any OF partions complain like this: ../arch/arm/boot/dts/gemini.dtsi:19.25-28.5: Warning (avoid_unnecessary_addr_size): /soc/flash@30000000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Get rid of this by only defining the address-cells and size-cells where it is actually used by OF partitions. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 ++ arch/arm/boot/dts/gemini-wbd111.dts | 2 ++ arch/arm/boot/dts/gemini-wbd222.dts | 2 ++ arch/arm/boot/dts/gemini.dtsi | 2 -- 4 files changed, 6 insertions(+), 2 deletions(-)