From patchwork Thu Dec 15 16:55:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13074364 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D4B3C4332F for ; Thu, 15 Dec 2022 16:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LI3Jr5scMy0XLPusDJbIOcL5/hKSKcYUeLzcSNqqizE=; b=LcyYNe5XgWJJPW z1MW4r+ipAsZM9wTBnLZ52mH/wD0U5jEjr0mJNVBKEv7iZHtNsTF9lHLNJ8mkX/aXAG5VTxDSy8qt 7pCBkoRm1KvSYq1Ivw5xLxENyFDWwlvkJfRuxqSABOARVz6wZPsFwJbhDUZOV42VZNS0taUlAX434 5qMaDGZ9pufscm4vjuT6ElbR3a0MbauKc1Jo2rFxYPdnkc0hgpnuA/21y//ZFnMxyZ4aDOAB6thhe Zb9PgJ8rwmnXnhdL8L7arCZOj6cShGSTiGp47Xrq1hlVJDwAdrZjmXCZByJqbIevpWeC+3fARAt5F qJ7MnVkkLu7uv7GQZRfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5rWJ-00AQ8x-Ds; Thu, 15 Dec 2022 16:55:43 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5rWG-00AQ72-RJ for linux-arm-kernel@lists.infradead.org; Thu, 15 Dec 2022 16:55:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id AD25CCE1CB3; Thu, 15 Dec 2022 16:55:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95C4BC433D2; Thu, 15 Dec 2022 16:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671123330; bh=e0u79or8elEwsfwUpsz+c2l+wQJQhYf3g9q0SWliS3o=; h=From:To:Cc:Subject:Date:From; b=ZyCSXA/j9R+dQ0abQp+TVmCEjDUd7CT1NRuxnu/QKvU1RMGpcHhDXg1nZmDSVYMoH xiYgapFtnTkNpnnuEzBBkJA1xCDGz64P00EseuYDIjzAD2O9Fy/AmeZw/YCsw4Vq4A LwpzCAd6RYAh8G8NY900KKzQVFyBRLhXjVcgU+DbZc35YxAA6w0OYQMh4PZJVI4RJn PsFe4KAAM8NSEk9sUwaNUd86njS4LXQeLgVVdn64pEeT4xVuSbZZuHksTJ9vImeQc8 EeiUDOOt4QuD92+YoyWs9qpQ4EgMJOHjDFh7JnsuhGaulmo8qBSDa/LmFBD246j6NS s1ue4rzNpJ1UQ== From: Arnd Bergmann To: Hector Martin , Sven Peter , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , Alyssa Rosenzweig , Marc Zyngier , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: apple: remove duplicate intializer Date: Thu, 15 Dec 2022 17:55:15 +0100 Message-Id: <20221215165523.1920672-1-arnd@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221215_085541_078520_03270F74 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann When -Woverride-init is enabled, gcc notices that the .attr field is initialized twice: drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init] 331 | .attr = apple_soc_cpufreq_hw_attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ Remove the first one, since this is not actually used. Signed-off-by: Arnd Bergmann Reviewed-by: Eric Curtin --- drivers/cpufreq/apple-soc-cpufreq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c index d1801281cdd9..6f26395184c4 100644 --- a/drivers/cpufreq/apple-soc-cpufreq.c +++ b/drivers/cpufreq/apple-soc-cpufreq.c @@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = { .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, - .attr = cpufreq_generic_attr, .get = apple_soc_cpufreq_get_rate, .init = apple_soc_cpufreq_init, .exit = apple_soc_cpufreq_exit,