From patchwork Wed Dec 21 20:05:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Frayer X-Patchwork-Id: 13079151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD5AC4332F for ; Wed, 21 Dec 2022 20:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qOOxgEzLyWxY+C/9W5MvMjwg/J1fxsROlSidMUpXWWs=; b=cWzdcm8aQ4KWPH 5QR9LfzW9GPIwUuYXk4F7nundCij2Lx/Vtta48/BTCKSI3jwk/vT49YuqU9JsWZPuWRVUBkAkPVk6 Bpu9Bv1QwgJqyF8DQrkuAiXc7YVOqIfMWCotziwaQYboVLTboTsd8BGqgK0ZNZwKyK1iG+kZ3wwcA tlN3TcocKEDqBBEYgHafXYXjpQJs38aOirGhTuuQ11XiBYnwp0iws+6KHu5OmGM0uq5036/AI0x5h Atjwa66UE+axm0GAlow26eHsP99ptPlhdrn8So+9Mah+LWV0QxPMow8277lZQaD/OJt+iwFE3T2sX aVPY4LCGhrzlwn6ax5qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p85Ln-001heQ-4g; Wed, 21 Dec 2022 20:06:03 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p85LD-001h66-6u for linux-arm-kernel@lists.infradead.org; Wed, 21 Dec 2022 20:05:30 +0000 Received: by mail-wm1-x333.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so2387010wma.1 for ; Wed, 21 Dec 2022 12:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GCVPxNOfZPjoH+iSfPJoYT9Y7Q3SbCUZMuBG+FFY/r4=; b=P1g+Cwpc1WDGimKmvk+WiCpsK7FonHsr//o5NpUfEEr9vCZaeBxP9iBUJzoz82tvpF /NBkcz7Zhc2dY4ZNFoXTB0DHvIP4Ncd0KQWuOoAiBpF7WDqwawtlqhvx1UFBx+JdICqk RGuEfqAquJV58Uzf/1ZeX2r5HnIszAuxaW0wdn8PVq5CsHj5CDS+c9SQyjhNFFmx0f7y 6Ao7kADIIXx+FB1hrI9uCn17nlJdBjufFE2wb7RudBeowmCfQ8bJKEd6F5MleHgevmkw axNGPie6p1QLHoIOSwuln22c+zMfr0H5QFdkk+tZAnaGwybslSC11t4DWRsT3PTJ4fpC PqKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GCVPxNOfZPjoH+iSfPJoYT9Y7Q3SbCUZMuBG+FFY/r4=; b=3cz/FMnCyJjYrlfIEQ/rNa8pSaJWKioIwFDKXhTNcNfVRP/9+l8o2ayigO3gsogH/C x7pKOWD0YsHTRKz93N2UqK7qDZduQsDNc64UZgWojhA9fH0ge2QyJbAfQx4PBcepnp6d jwZHo7YLMWMwq3OZS7xo2WXV50j9maN1BVeEP0qaTz2I+CyO8QUUskUirsw6I3Dur8Qh bnOv4zCPWRE6IdkluX27ivGE1ZUng5meeOgOzNPgRvv7PlZsxc1YkXHQFtjViu24wcfN 0JBD5yh6Uu+U0EpTm2M0AExTqW3Qr7h5/xzmW1H0yM06hMLWS+DbB0jVbP1M9r37PRkN dDCg== X-Gm-Message-State: AFqh2krxeZ1XIXFbKjBv7AifUOvrLHwev6heFJluYHGH1mnB7qjgb4pV k9brYSc4aTbzPZWHhIfjpLhESQ== X-Google-Smtp-Source: AMrXdXvhuOTSVIVG4TGZTo4fZC4E470tM06O66vurlp8EVhJ4shdZuEGn/93xrjjXnc5xBIFnQJ+oQ== X-Received: by 2002:a05:600c:3b83:b0:3d3:864a:116e with SMTP id n3-20020a05600c3b8300b003d3864a116emr2565423wms.26.1671653122511; Wed, 21 Dec 2022 12:05:22 -0800 (PST) Received: from nicolas-Precision-3551.home ([2001:861:5180:dcc0:3a9d:700a:1a4b:216a]) by smtp.gmail.com with ESMTPSA id u18-20020adfeb52000000b002423dc3b1a9sm15943228wrn.52.2022.12.21.12.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 12:05:21 -0800 (PST) From: Nicolas Frayer To: peter.ujfalusi@gmail.com, nm@ti.com, ssantosh@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, grygorii.strashko@ti.com, khilman@baylibre.com, mkorpershoek@baylibre.com, nfrayer@baylibre.com Subject: [PATCH] soc: ti: k3-ringacc: Add try_module_get() to k3_dmaring_request_dual_ring() Date: Wed, 21 Dec 2022 21:05:13 +0100 Message-Id: <20221221200513.676744-1-nfrayer@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_120527_481882_0C6F78F4 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the k3 ring accelerator driver has been modified to add module build support, try_module_get() and module_put() have been added to update the module refcnt. One code path has not been updated and it has introduced an issue where the refcnt is decremented by module_put() in k3_ringacc_ring_free() without being incremented previously. Adding try_module_get() to k3_dmaring_request_dual_ring() ensures the refcnt is kept up to date. Signed-off-by: Nicolas Frayer Reviewed-by: Peter Ujfalusi --- drivers/soc/ti/k3-ringacc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c index e01e4d815230a..8f131368a7586 100644 --- a/drivers/soc/ti/k3-ringacc.c +++ b/drivers/soc/ti/k3-ringacc.c @@ -406,6 +406,11 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id, mutex_lock(&ringacc->req_lock); + if (!try_module_get(ringacc->dev->driver->owner)) { + ret = -EINVAL; + goto err_module_get; + } + if (test_bit(fwd_id, ringacc->rings_inuse)) { ret = -EBUSY; goto error; @@ -421,6 +426,8 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id, return 0; error: + module_put(ringacc->dev->driver->owner); +err_module_get: mutex_unlock(&ringacc->req_lock); return ret; }