From patchwork Fri Dec 23 12:24:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13080956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DB19C4332F for ; Fri, 23 Dec 2022 12:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FHvW4mY//wXefBwYRGDEgl64Nn3kqav6sGbK/fv3bYI=; b=uZXA7PGW/elTxz tf30XLxFFkQaTmJxrLfbbjBbj1w+e2uxrhvzZW7NAh6dN7QClO3GBhhqRItGO2BkowiQy0AOoFEB4 swZdE4NAd1udf04s3QoSa0Zj4i1MM5Lfpp7EG0iRP2LIujrdt9c5gHOm8n6sl6mbcvJSCxGtudB2p NYeXEj5qFsy7H609QfB+eu9p9taepYvNiFLsGW7B/xEfWDecexiagsik4UNn4QeTQWI+iGqaWebk9 Phq2hFPyhNXmSx8sKBVjKfTims1yOmONa7qlWV8axXhuT/dkPIHLVG1zGv1o3WOxwCNSkMNis1viy poXeffuk4SRWHleBkiEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8h9X-007wja-J6; Fri, 23 Dec 2022 12:27:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8h6v-007vc1-Eg; Fri, 23 Dec 2022 12:25:14 +0000 Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3f:cd5d:4e48:3b91:9262:9565]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 682D0492; Fri, 23 Dec 2022 13:25:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671798312; bh=Xo4PgGMqXkAeAbAXamG4Agqq6zDHS6a3JUw2oXCCxcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aNHAgoxhvTZb5g/t3sRmdo1fISxhqSourtvk2a6eUsvsZPlWCVyxocjj+Da9i7fUm RJOWfsT+76+cpSo1/4CPtZ/DgZDsJq/scSBkKsTnPPY9a2uPK4GJwDSbDcYsUpx9wC 1+hH65ZUd5Ec74/lm9JrevRiirNA5uuSBAgSLwiE= From: Umang Jain To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Date: Fri, 23 Dec 2022 17:54:04 +0530 Message-Id: <20221223122404.170585-8-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221223122404.170585-1-umang.jain@ideasonboard.com> References: <20221223122404.170585-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221223_042513_692112_9B2E65E8 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The custom return values (enum vchiq_status) has been dropped. Remove the TODO entry for the same. Signed-off-by: Umang Jain Tested-by: Stefan Wahren --- drivers/staging/vc04_services/interface/TODO | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 97085a0b3223..6d9d4a800aa7 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -40,11 +40,6 @@ beneficial to go over all of them and, if correct, comment on their merits. Extra points to whomever confidently reviews the remote_event_*() family of functions. -* Get rid of custom function return values - -Most functions use a custom set of return values, we should force proper Linux -error numbers. Special care is needed for VCHIQ_RETRY. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of