| Message ID | 20230102115255.17802-1-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] firmware: raspberrypi: Fix type assignment | expand |
On 1/2/23 03:52, Maxime Ripard wrote: > We silently cast an unsigned int into a __le32 which makes sparse > complain. Moreover, we never actually convert endianness between the > CPU's and the expected little-endian value. Fix both at once by calling > cpu_to_le32(). > > Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/r/20221116091712.1309651-3-maxime@cerno.tech > Signed-off-by: Maxime Ripard <maxime@cerno.tech> As soon as v6.2-rc1 is cut, I will pick this up, thanks Maxime. > --- > include/soc/bcm2835/raspberrypi-firmware.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h > index ab955591cb72..73cac8d0287e 100644 > --- a/include/soc/bcm2835/raspberrypi-firmware.h > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > @@ -170,7 +170,7 @@ struct rpi_firmware_clk_rate_request { > > #define RPI_FIRMWARE_CLK_RATE_REQUEST(_id) \ > { \ > - .id = _id, \ > + .id = cpu_to_le32(_id), \ > } > > #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE)
Hi Florian, On Tue, Jan 03, 2023 at 03:44:24PM -0800, Florian Fainelli wrote: > On 1/2/23 03:52, Maxime Ripard wrote: > > We silently cast an unsigned int into a __le32 which makes sparse > > complain. Moreover, we never actually convert endianness between the > > CPU's and the expected little-endian value. Fix both at once by calling > > cpu_to_le32(). > > > > Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate") > > Reported-by: kernel test robot <lkp@intel.com> > > Link: https://lore.kernel.org/r/20221116091712.1309651-3-maxime@cerno.tech > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > As soon as v6.2-rc1 is cut, I will pick this up, thanks Maxime. I'm not sure what you mean, we're at -rc2 already? Maxime
On Mon, 2 Jan 2023 12:52:55 +0100, Maxime Ripard <maxime@cerno.tech> wrote: > We silently cast an unsigned int into a __le32 which makes sparse > complain. Moreover, we never actually convert endianness between the > CPU's and the expected little-endian value. Fix both at once by calling > cpu_to_le32(). > > Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/r/20221116091712.1309651-3-maxime@cerno.tech > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/fixes, thanks! -- Florian
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h index ab955591cb72..73cac8d0287e 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h @@ -170,7 +170,7 @@ struct rpi_firmware_clk_rate_request { #define RPI_FIRMWARE_CLK_RATE_REQUEST(_id) \ { \ - .id = _id, \ + .id = cpu_to_le32(_id), \ } #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE)
We silently cast an unsigned int into a __le32 which makes sparse complain. Moreover, we never actually convert endianness between the CPU's and the expected little-endian value. Fix both at once by calling cpu_to_le32(). Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/r/20221116091712.1309651-3-maxime@cerno.tech Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- include/soc/bcm2835/raspberrypi-firmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)