| Message ID | 20230102140402.582698-1-festevam@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8m-venice: Remove incorrect 'uart-has-rtscts' | expand |
On Mon, Jan 2, 2023 at 6:04 AM Fabio Estevam <festevam@denx.de> wrote: > > The following build warnings are seen when running: > > make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml > > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]] > From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]] > From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml > ... > > The imx8m Venice Gateworks boards do not expose the UART RTS and CTS > as native UART pins, so 'uart-has-rtscts' should not be used. > > Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination > detected by serial.yaml. > > Fix the problem by removing the incorrect 'uart-has-rtscts' property. > > Fixes: 27c8f4ccc1b9 ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes") > Fixes: d9a9a7cf32c9 ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs") > Fixes: 870f645b396b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support") > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 1 - > .../boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso | 1 - > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 1 - > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 3 --- > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 3 --- > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts | 1 - > arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 - > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 1 - > 8 files changed, 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso > index 3ea73a6886ff..f6ad1a4b8b66 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso > @@ -33,7 +33,6 @@ > pinctrl-0 = <&pinctrl_uart2>; > rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso > index 2fa635e1c1a8..1f8ea20dfafc 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso > @@ -33,7 +33,6 @@ > pinctrl-0 = <&pinctrl_uart2>; > rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > index 244ef8d6cc68..7761d5671cb1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > @@ -222,7 +222,6 @@ &uart3 { > pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>; > cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>; > rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > > bluetooth { > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > index 750a1f07ecb7..a186df2f833f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > @@ -733,7 +733,6 @@ &uart1 { > dtr-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>; > dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; > dcd-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > @@ -749,7 +748,6 @@ &uart3 { > pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; > cts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>; > rts-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > @@ -758,7 +756,6 @@ &uart4 { > pinctrl-0 = <&pinctrl_uart4>, <&pinctrl_uart4_gpio>; > cts-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>; > rts-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts > index 32872b0b1aaf..e8bc1fccc47b 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts > @@ -664,7 +664,6 @@ &uart1 { > pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>; > rts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > @@ -681,7 +680,6 @@ &uart3 { > pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; > rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > > bluetooth { > @@ -699,7 +697,6 @@ &uart4 { > dtr-gpios = <&gpio4 3 GPIO_ACTIVE_LOW>; > dsr-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>; > dcd-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts > index 8ce562246a08..acc2ba8e00a8 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts > @@ -581,7 +581,6 @@ &uart1 { > dtr-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; > dcd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts > index b9444e4a3d2d..7c12518dbc96 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts > @@ -643,7 +643,6 @@ &uart3 { > pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; > rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > > bluetooth { > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > index ceeca4966fc5..8eb7d5ee38da 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > @@ -623,7 +623,6 @@ &uart3 { > pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; > cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>; > rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>; > - uart-has-rtscts; > status = "okay"; > > bluetooth { > -- > 2.25.1 > Fabio, Acked-by: Tim Harvey <tharvey@gateworks.com> Thanks, Tim
On Mon, Jan 02, 2023 at 11:04:02AM -0300, Fabio Estevam wrote: > The following build warnings are seen when running: > > make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml > > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]] > From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]] > From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml > ... > > The imx8m Venice Gateworks boards do not expose the UART RTS and CTS > as native UART pins, so 'uart-has-rtscts' should not be used. > > Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination > detected by serial.yaml. > > Fix the problem by removing the incorrect 'uart-has-rtscts' property. > > Fixes: 27c8f4ccc1b9 ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes") > Fixes: d9a9a7cf32c9 ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs") > Fixes: 870f645b396b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support") > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso index 3ea73a6886ff..f6ad1a4b8b66 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso @@ -33,7 +33,6 @@ pinctrl-0 = <&pinctrl_uart2>; rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>; cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso index 2fa635e1c1a8..1f8ea20dfafc 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso @@ -33,7 +33,6 @@ pinctrl-0 = <&pinctrl_uart2>; rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>; cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi index 244ef8d6cc68..7761d5671cb1 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi @@ -222,7 +222,6 @@ &uart3 { pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>; cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>; rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; bluetooth { diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts index 750a1f07ecb7..a186df2f833f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts @@ -733,7 +733,6 @@ &uart1 { dtr-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>; dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; dcd-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; @@ -749,7 +748,6 @@ &uart3 { pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; cts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>; rts-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; @@ -758,7 +756,6 @@ &uart4 { pinctrl-0 = <&pinctrl_uart4>, <&pinctrl_uart4_gpio>; cts-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>; rts-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts index 32872b0b1aaf..e8bc1fccc47b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts @@ -664,7 +664,6 @@ &uart1 { pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>; rts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>; cts-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; @@ -681,7 +680,6 @@ &uart3 { pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; bluetooth { @@ -699,7 +697,6 @@ &uart4 { dtr-gpios = <&gpio4 3 GPIO_ACTIVE_LOW>; dsr-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>; dcd-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts index 8ce562246a08..acc2ba8e00a8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts @@ -581,7 +581,6 @@ &uart1 { dtr-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; dcd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts index b9444e4a3d2d..7c12518dbc96 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts +++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts @@ -643,7 +643,6 @@ &uart3 { pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; bluetooth { diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index ceeca4966fc5..8eb7d5ee38da 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -623,7 +623,6 @@ &uart3 { pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>; cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>; rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>; - uart-has-rtscts; status = "okay"; bluetooth {
The following build warnings are seen when running: make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]] From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]] From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml ... The imx8m Venice Gateworks boards do not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used. Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by serial.yaml. Fix the problem by removing the incorrect 'uart-has-rtscts' property. Fixes: 27c8f4ccc1b9 ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes") Fixes: d9a9a7cf32c9 ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs") Fixes: 870f645b396b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support") Signed-off-by: Fabio Estevam <festevam@denx.de> --- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 1 - .../boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso | 1 - arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 1 - arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 3 --- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 3 --- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts | 1 - arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 - arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 1 - 8 files changed, 12 deletions(-)