diff mbox series

[v2,2/5] arm64: dts: fsl-imx8qm-device.dtsi: add io-channel-cells to adc nodes

Message ID 20230102171023.33853-3-marcel@ziswiler.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: freescale: prepare and add apalis imx8 support | expand

Commit Message

Marcel Ziswiler Jan. 2, 2023, 5:10 p.m. UTC
From: Max Krummenacher <max.krummenacher@toradex.com>

This commit adds io-channel-cells property to the ADC nodes. This
property is required in order for an IIO consumer driver to work.
Especially required for Apalis iMX8 QM, as the touchscreen driver
uses ADC channels with the ADC driver based on IIO framework.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

(no changes since v1)

 arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shawn Guo Jan. 9, 2023, 8:19 a.m. UTC | #1
On Mon, Jan 02, 2023 at 06:10:19PM +0100, Marcel Ziswiler wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> This commit adds io-channel-cells property to the ADC nodes. This
> property is required in order for an IIO consumer driver to work.
> Especially required for Apalis iMX8 QM, as the touchscreen driver
> uses ADC channels with the ADC driver based on IIO framework.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

fsl-imx8qm-device.dtsi in subject?

Shawn

> ---
> 
> (no changes since v1)
> 
>  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index a943a1e2797f..6e5ef8b69bf8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -270,6 +270,7 @@ i2c3: i2c@5a830000 {
>  
>  	adc0: adc@5a880000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a880000 0x10000>;
>  		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;
> @@ -284,6 +285,7 @@ adc0: adc@5a880000 {
>  
>  	adc1: adc@5a890000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a890000 0x10000>;
>  		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;
> -- 
> 2.35.1
>
Marcel Ziswiler Jan. 9, 2023, 9:23 a.m. UTC | #2
On Mon, 2023-01-09 at 16:19 +0800, Shawn Guo wrote:
> On Mon, Jan 02, 2023 at 06:10:19PM +0100, Marcel Ziswiler wrote:
> > From: Max Krummenacher <max.krummenacher@toradex.com>
> > 
> > This commit adds io-channel-cells property to the ADC nodes. This
> > property is required in order for an IIO consumer driver to work.
> > Especially required for Apalis iMX8 QM, as the touchscreen driver
> > uses ADC channels with the ADC driver based on IIO framework.
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> fsl-imx8qm-device.dtsi in subject?

(;-p).

Let me fix this in a v3. Thanks!

> Shawn

Cheers

Marcel

> > ---
> > 
> > (no changes since v1)
> > 
> >  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-
> > dma.dtsi
> > index a943a1e2797f..6e5ef8b69bf8 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > @@ -270,6 +270,7 @@ i2c3: i2c@5a830000 {
> >  
> >         adc0: adc@5a880000 {
> >                 compatible = "nxp,imx8qxp-adc";
> > +               #io-channel-cells = <1>;
> >                 reg = <0x5a880000 0x10000>;
> >                 interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
> >                 interrupt-parent = <&gic>;
> > @@ -284,6 +285,7 @@ adc0: adc@5a880000 {
> >  
> >         adc1: adc@5a890000 {
> >                 compatible = "nxp,imx8qxp-adc";
> > +               #io-channel-cells = <1>;
> >                 reg = <0x5a890000 0x10000>;
> >                 interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
> >                 interrupt-parent = <&gic>;
> > -- 
> > 2.35.1
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index a943a1e2797f..6e5ef8b69bf8 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -270,6 +270,7 @@  i2c3: i2c@5a830000 {
 
 	adc0: adc@5a880000 {
 		compatible = "nxp,imx8qxp-adc";
+		#io-channel-cells = <1>;
 		reg = <0x5a880000 0x10000>;
 		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;
@@ -284,6 +285,7 @@  adc0: adc@5a880000 {
 
 	adc1: adc@5a890000 {
 		compatible = "nxp,imx8qxp-adc";
+		#io-channel-cells = <1>;
 		reg = <0x5a890000 0x10000>;
 		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-parent = <&gic>;