From patchwork Sat Jan 7 14:41:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Kudielka X-Patchwork-Id: 13092185 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEA12C54EBC for ; Sat, 7 Jan 2023 14:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9rvEJR52yqLGOhox2QRLF/qAImHBqkGtbqyIE71Rj88=; b=UvY77LYRHukZh8 OsIXG6A1o1r4XzcxWvPbf9UNsIgZmJ6lNhHLPgR61gHIZvTRPNNqKj9rHKIW4p/C2w5maKFylAkCf uagvUPpfEWKul1sz6eQwyd7X8W7hjHUoZd91dKnhAxnrwm9WLc5KqbGA9NlHfhdzZHEGeMp/2A6pN AqwqzND60jqTOhI9+aDaMe8epfzhvFfzy+3N5dOcb09rUiJrkWAAGS90d7hxW5IdJckiCJl3gzURs qrrBq8iCE5KQsUX1VdjII2mlM7BHon2hXnk6j90Um/SuIawhykwuVFDrHvz1gqXcVZ9Zo1171Jwg2 KevbadkCimLcCVVjJ96g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEAQA-007PAR-SH; Sat, 07 Jan 2023 14:43:42 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEAPw-007OnH-2l for linux-arm-kernel@lists.infradead.org; Sat, 07 Jan 2023 14:43:29 +0000 Received: by mail-wm1-x329.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso2986898wms.5 for ; Sat, 07 Jan 2023 06:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KflpauUnWgC57RkikrRwZ2S6zi1pavAFyzypxpmWhoY=; b=Tqv56ClWmcwHVhAUExXSWB5Pp3P0Zu7LJIe/Bl+SGUESQ/WQIHSuKzg0Y3jwA2+IIs QKJknyep1mSJ3Z0JDDEyCYB9+fdRAnBJAiz1t43ArrxDA6AcMDGlkgyVfV74tHt1KciO EwWyxR2hAXrAaG+1EkG1yWvv8R9YxCShXQADAMcPTzms3xTr5S7Us2mmyO0P6BHx8eBH eYgEZ+JXQ5tQvNr4xzuCPuVQIPSo87Zf6XL47R11boJZw/PAKNoLNwyi34NISpNqwQOH W8/shlStEn+YnhUgCerNn/lYkf16RtZC2sIit3L9cSJLGft1fBwCp8ZdK47vLIR5f3KA EDOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KflpauUnWgC57RkikrRwZ2S6zi1pavAFyzypxpmWhoY=; b=FpHBdrmriqLzCQ9IG45aBRUJvjFvYGbOI2KJx8ghSY6oabjyaPiSmlNWKNrSbl4iFU l9I7tQympRjfsoACfJceDb+ymUtnpgC577AjW02bChBfz8rEbgr1Mz1pwsbBNmDHJ43G t+lyKuBmJiI9gvCcoYh7o/mSlzJW9nokcBtkDk8iNOB5eZOFQLl60zsAnKFVGEt38/sV y3SKKGPdSwmAxSXdsJRBq2h6LI2HCYCgDJJs4bI3vrN2Tacqs4xtCr3XFbQusOnxwK4l VeyZFcmtKGUyU4D1BRNY0HTYP/613VgzW9hKi5mFPK9Qun3gH41myNZ3i9V+HpiWF/R8 8TBw== X-Gm-Message-State: AFqh2koYqScMdmAOEijVaAANIYwZWLoqAx9XPsd5gjOFuB18II4mARH5 C3P1uNUdHnwMrGpLVsLSI1Y= X-Google-Smtp-Source: AMrXdXugbobdJRCM/3Fbu5r/3k2S8rpVOY4LyMoUQ1NuYbYL5zwd0A/ZbX0xojfBzW3C4wk+iHiWtQ== X-Received: by 2002:a05:600c:42c7:b0:3d2:3ae8:885b with SMTP id j7-20020a05600c42c700b003d23ae8885bmr41848980wme.28.1673102605972; Sat, 07 Jan 2023 06:43:25 -0800 (PST) Received: from mars.. ([2a02:168:6806:0:40f6:41b6:8914:e80b]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003d9a86a13bfsm6056106wmq.28.2023.01.07.06.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 06:43:25 -0800 (PST) From: Klaus Kudielka To: "Andrew Lunn" , "Gregory Clement" , "Sebastian Hesselbarth" , "Rob Herring" , "Krzysztof Kozlowski" , =?utf-8?q?Pali_R?= =?utf-8?q?oh=C3=A1r?= , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: Thomas Petazzoni , Chris Packham , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Klaus Kudielka Subject: [PATCH v2 2/2] Revert "ARM: dts: armada-39x: Fix compatible string for gpios" Date: Sat, 7 Jan 2023 15:41:49 +0100 Message-Id: <20230107144149.5743-2-klaus.kudielka@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230107144149.5743-1-klaus.kudielka@gmail.com> References: <20230107144149.5743-1-klaus.kudielka@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230107_064328_141013_973581E7 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit d10886a4e6f85ee18d47a1066a52168461370ded. If compatible = "marvell,armadaxp-gpio", the reg property requires a second (address, size) pair, which points to the per-CPU interrupt registers <0x18800 0x30> / <0x18840 0x30>. Furthermore: Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not work reliably with per-CPU interrupts. Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this reason. Signed-off-by: Klaus Kudielka Reviewed-by: Andrew Lunn --- v1->v2: Be more explicit about the reg property. arch/arm/boot/dts/armada-39x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi index 1e05208d9f..9d1cac49c0 100644 --- a/arch/arm/boot/dts/armada-39x.dtsi +++ b/arch/arm/boot/dts/armada-39x.dtsi @@ -213,7 +213,7 @@ nand_pins: nand-pins { }; gpio0: gpio@18100 { - compatible = "marvell,armadaxp-gpio", "marvell,orion-gpio"; + compatible = "marvell,orion-gpio"; reg = <0x18100 0x40>; ngpios = <32>; gpio-controller; @@ -227,7 +227,7 @@ gpio0: gpio@18100 { }; gpio1: gpio@18140 { - compatible = "marvell,armadaxp-gpio", "marvell,orion-gpio"; + compatible = "marvell,orion-gpio"; reg = <0x18140 0x40>; ngpios = <28>; gpio-controller;