| Message ID | 20230111050200.2130-1-noor.azura.ahmad.tarmizi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [net,v2,1/1] net: stmmac: add aux timestamps fifo clearance wait | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 11 Jan 2023 13:02:00 +0800 you wrote: > Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit > (ATSFC) to clear. This is to ensure no residue fifo value is being read > erroneously. > > Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping") > Cc: <stable@vger.kernel.org> # 5.10.x > Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com> > > [...] Here is the summary with links: - [net,v2,1/1] net: stmmac: add aux timestamps fifo clearance wait https://git.kernel.org/netdev/net/c/ae9dcb91c606 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c index fc06ddeac0d5..b4388ca8d211 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c @@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp, } writel(acr_value, ptpaddr + PTP_ACR); mutex_unlock(&priv->aux_ts_lock); - ret = 0; + /* wait for auxts fifo clear to finish */ + ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value, + !(acr_value & PTP_ACR_ATSFC), + 10, 10000); break; default:
Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit (ATSFC) to clear. This is to ensure no residue fifo value is being read erroneously. Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping") Cc: <stable@vger.kernel.org> # 5.10.x Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)