| Message ID | 20230112-imx-pxp-v2-8-e2281da1db55@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: imx-pxp: add support for i.MX7D | expand |
On Fr, 2023-01-13 at 10:54 +0100, Michael Tretter wrote: > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > node to make it available. > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
Hi Michael, (CC'ing Shawn) On Fri, Jan 13, 2023 at 10:54:14AM +0100, Michael Tretter wrote: > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > node to make it available. > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> Should this go through Shawn's tree ? If so, how would you like to handle the dependency on the DT bindings in patch 01/16 ? > --- > Changelog > > v2: > > - fix alignment > --- > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > index 7ceb7c09f7ad..4b94b8afb55d 100644 > --- a/arch/arm/boot/dts/imx7d.dtsi > +++ b/arch/arm/boot/dts/imx7d.dtsi > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > reg = <0x306d0000 0x10000>; > status = "disabled"; > }; > + > + pxp: pxp@30700000 { > + compatible = "fsl,imx7d-pxp"; > + reg = <0x30700000 0x10000>; > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX7D_PXP_CLK>; > + clock-names = "axi"; > + }; > }; > > &aips3 {
On Mon, 16 Jan 2023 18:26:49 +0200, Laurent Pinchart wrote: > On Fri, Jan 13, 2023 at 10:54:14AM +0100, Michael Tretter wrote: > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > node to make it available. > > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > > Should this go through Shawn's tree ? If so, how would you like to > handle the dependency on the DT bindings in patch 01/16 ? There is no actual dependency. The binding was already specified as a txt, just not as a yaml, and the added node matches both. Michael > > > --- > > Changelog > > > > v2: > > > > - fix alignment > > --- > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > index 7ceb7c09f7ad..4b94b8afb55d 100644 > > --- a/arch/arm/boot/dts/imx7d.dtsi > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > reg = <0x306d0000 0x10000>; > > status = "disabled"; > > }; > > + > > + pxp: pxp@30700000 { > > + compatible = "fsl,imx7d-pxp"; > > + reg = <0x30700000 0x10000>; > > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clks IMX7D_PXP_CLK>; > > + clock-names = "axi"; > > + }; > > }; > > > > &aips3 {
On Fri, Jan 20, 2023 at 10:06:09AM +0100, Michael Tretter wrote: > On Mon, 16 Jan 2023 18:26:49 +0200, Laurent Pinchart wrote: > > On Fri, Jan 13, 2023 at 10:54:14AM +0100, Michael Tretter wrote: > > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > > node to make it available. > > > > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > > > > Should this go through Shawn's tree ? If so, how would you like to > > handle the dependency on the DT bindings in patch 01/16 ? > > There is no actual dependency. The binding was already specified as a txt, > just not as a yaml, and the added node matches both. Good point. I'll send a pull request for the series then, without this patch, which can be picked by Shawn separately. > > > --- > > > Changelog > > > > > > v2: > > > > > > - fix alignment > > > --- > > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > > index 7ceb7c09f7ad..4b94b8afb55d 100644 > > > --- a/arch/arm/boot/dts/imx7d.dtsi > > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > > reg = <0x306d0000 0x10000>; > > > status = "disabled"; > > > }; > > > + > > > + pxp: pxp@30700000 { > > > + compatible = "fsl,imx7d-pxp"; > > > + reg = <0x30700000 0x10000>; > > > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&clks IMX7D_PXP_CLK>; > > > + clock-names = "axi"; > > > + }; > > > }; > > > > > > &aips3 {
Hi Shawn, On Fri, 20 Jan 2023 11:20:24 +0200, Laurent Pinchart wrote: > On Fri, Jan 20, 2023 at 10:06:09AM +0100, Michael Tretter wrote: > > On Mon, 16 Jan 2023 18:26:49 +0200, Laurent Pinchart wrote: > > > On Fri, Jan 13, 2023 at 10:54:14AM +0100, Michael Tretter wrote: > > > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > > > node to make it available. > > > > > > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > > > > > > Should this go through Shawn's tree ? If so, how would you like to > > > handle the dependency on the DT bindings in patch 01/16 ? > > > > There is no actual dependency. The binding was already specified as a txt, > > just not as a yaml, and the added node matches both. > > Good point. I'll send a pull request for the series then, without this > patch, which can be picked by Shawn separately. Can you pick this patch or should I resend it as a separate series? Michael > > > > > --- > > > > Changelog > > > > > > > > v2: > > > > > > > > - fix alignment > > > > --- > > > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > > > 1 file changed, 9 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > > > index 7ceb7c09f7ad..4b94b8afb55d 100644 > > > > --- a/arch/arm/boot/dts/imx7d.dtsi > > > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > > > reg = <0x306d0000 0x10000>; > > > > status = "disabled"; > > > > }; > > > > + > > > > + pxp: pxp@30700000 { > > > > + compatible = "fsl,imx7d-pxp"; > > > > + reg = <0x30700000 0x10000>; > > > > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, > > > > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; > > > > + clocks = <&clks IMX7D_PXP_CLK>; > > > > + clock-names = "axi"; > > > > + }; > > > > }; > > > > > > > > &aips3 {
On Thu, Feb 09, 2023 at 03:02:25PM +0100, Michael Tretter wrote: > Hi Shawn, > > On Fri, 20 Jan 2023 11:20:24 +0200, Laurent Pinchart wrote: > > On Fri, Jan 20, 2023 at 10:06:09AM +0100, Michael Tretter wrote: > > > On Mon, 16 Jan 2023 18:26:49 +0200, Laurent Pinchart wrote: > > > > On Fri, Jan 13, 2023 at 10:54:14AM +0100, Michael Tretter wrote: > > > > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > > > > node to make it available. > > > > > > > > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > > > > > > > > Should this go through Shawn's tree ? If so, how would you like to > > > > handle the dependency on the DT bindings in patch 01/16 ? > > > > > > There is no actual dependency. The binding was already specified as a txt, > > > just not as a yaml, and the added node matches both. > > > > Good point. I'll send a pull request for the series then, without this > > patch, which can be picked by Shawn separately. > > Can you pick this patch or should I resend it as a separate series? Applied, thanks!
diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index 7ceb7c09f7ad..4b94b8afb55d 100644 --- a/arch/arm/boot/dts/imx7d.dtsi +++ b/arch/arm/boot/dts/imx7d.dtsi @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { reg = <0x306d0000 0x10000>; status = "disabled"; }; + + pxp: pxp@30700000 { + compatible = "fsl,imx7d-pxp"; + reg = <0x30700000 0x10000>; + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX7D_PXP_CLK>; + clock-names = "axi"; + }; }; &aips3 {
The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree node to make it available. Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> --- Changelog v2: - fix alignment --- arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)