| Message ID | 20230118154450.73842-4-andrzej.hajda@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce __xchg, non-atomic xchg | expand |
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:47PM +0100, Andrzej Hajda wrote: > llist_del_all uses xchg, let's use __xchg here. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi
diff --git a/include/linux/llist.h b/include/linux/llist.h index 85bda2d02d65be..4dc1d185ea98ab 100644 --- a/include/linux/llist.h +++ b/include/linux/llist.h @@ -50,6 +50,7 @@ #include <linux/atomic.h> #include <linux/container_of.h> +#include <linux/non-atomic/xchg.h> #include <linux/stddef.h> #include <linux/types.h> @@ -241,10 +242,7 @@ static inline struct llist_node *llist_del_all(struct llist_head *head) static inline struct llist_node *__llist_del_all(struct llist_head *head) { - struct llist_node *first = head->first; - - head->first = NULL; - return first; + return __xchg(&head->first, NULL); } extern struct llist_node *llist_del_first(struct llist_head *head);
llist_del_all uses xchg, let's use __xchg here. Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> --- include/linux/llist.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)