| Message ID | 202301191514074846351@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [linux-next] fpga: xilinx-pr-decoupler: Use devm_platform_get_and_ioremap_resource() | expand |
On 1/19/23 08:14, ye.xingchen@zte.com.cn wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/fpga/xilinx-pr-decoupler.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index 2d9c491f7be9..0039cf11ddd5 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) > struct xlnx_pr_decoupler_data *priv; > struct fpga_bridge *br; > int err; > - struct resource *res; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) > priv->ipconfig = match->data; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->io_base = devm_ioremap_resource(&pdev->dev, res); > + priv->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); > if (IS_ERR(priv->io_base)) > return PTR_ERR(priv->io_base); > > -- > 2.25.1 Reviewed-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c index 2d9c491f7be9..0039cf11ddd5 100644 --- a/drivers/fpga/xilinx-pr-decoupler.c +++ b/drivers/fpga/xilinx-pr-decoupler.c @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) struct xlnx_pr_decoupler_data *priv; struct fpga_bridge *br; int err; - struct resource *res; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) priv->ipconfig = match->data; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - priv->io_base = devm_ioremap_resource(&pdev->dev, res); + priv->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(priv->io_base)) return PTR_ERR(priv->io_base);