diff mbox series

[2/2] arm64: dts: stratix10: add i2c pins for pinctrl

Message ID 20230123192712.84537-2-dinguyen@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: add pinctrl-single property for Stratix10/Agilex | expand

Commit Message

Dinh Nguyen Jan. 23, 2023, 7:27 p.m. UTC 
Add the I2C pins definition to the Stratix10 devkit. This allows for the
I2C driver to use pinctrl on the pins to allow for GPIO recovery.

Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 .../dts/altera/socfpga_stratix10_socdk.dts    | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Krzysztof Kozlowski Jan. 23, 2023, 7:30 p.m. UTC | #1 
On 23/01/2023 20:27, Dinh Nguyen wrote:
> Add the I2C pins definition to the Stratix10 devkit. This allows for the
> I2C driver to use pinctrl on the pins to allow for GPIO recovery.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
>  .../dts/altera/socfpga_stratix10_socdk.dts    | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 17752ca743e5..beda04b9380b 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -65,6 +65,22 @@ sdmmca-ecc@ff8c8c00 {
>  	};
>  };
>  
> +&pinctrl0 {
> +	i2c1_pmx_func: i2c1_pmx_func {

No underscores in node names.

> +		pinctrl-single,pins = <
> +			0x78   0x4   /* I2C1_SDA (IO6-B) PIN30SEL) */
> +			0x7c   0x4   /* I2C1_SCL (IO7-B) PIN31SEL */
> +		>;
> +	};
> +
> +	i2c1_pmx_func_gpio: i2c1_pmx_func_gpio {

Same here.

> +		pinctrl-single,pins = <
> +			0x78   0x8   /* I2C1_SDA (IO6-B) PIN30SEL) */
> +			0x7c   0x8   /* I2C1_SCL (IO7-B) PIN31SEL */
> +		>;
> +	};
> +};
> +
>  &gpio1 {
Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 17752ca743e5..beda04b9380b 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -65,6 +65,22 @@  sdmmca-ecc@ff8c8c00 {
 	};
 };
 
+&pinctrl0 {
+	i2c1_pmx_func: i2c1_pmx_func {
+		pinctrl-single,pins = <
+			0x78   0x4   /* I2C1_SDA (IO6-B) PIN30SEL) */
+			0x7c   0x4   /* I2C1_SCL (IO7-B) PIN31SEL */
+		>;
+	};
+
+	i2c1_pmx_func_gpio: i2c1_pmx_func_gpio {
+		pinctrl-single,pins = <
+			0x78   0x8   /* I2C1_SDA (IO6-B) PIN30SEL) */
+			0x7c   0x8   /* I2C1_SCL (IO7-B) PIN31SEL */
+		>;
+	};
+};
+
 &gpio1 {
 	status = "okay";
 };
@@ -131,6 +147,13 @@  &i2c1 {
 	i2c-sda-falling-time-ns = <890>;  /* hcnt */
 	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
 
+	pinctrl-names = "default", "gpio";
+	pinctrl-0 = <&i2c1_pmx_func>;
+	pinctrl-1 = <&i2c1_pmx_func_gpio>;
+
+	scl-gpios = <&portb 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+	sda-gpios = <&portb 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+
 	adc@14 {
 		compatible = "lltc,ltc2497";
 		reg = <0x14>;