| Message ID | 20230124154053.355376-2-pierre.gondois@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cacheinfo: Fix misbehaviours around init_cache_level() | expand |
On Tue, Jan 24, 2023 at 04:40:46PM +0100, Pierre Gondois wrote: > Set potentially uninitialized variables to 0. This is particularly > relevant when CONFIG_ACPI_PPTT is not set. > > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202301052307.JYt1GWaJ-lkp@intel.com/ > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/ > Fixes: 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU") > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks for the quick respin Pierre :) > --- > drivers/base/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c > index 418a18acc8f9..f6573c335f4c 100644 > --- a/drivers/base/cacheinfo.c > +++ b/drivers/base/cacheinfo.c > @@ -424,7 +424,7 @@ int allocate_cache_info(int cpu) > int fetch_cache_info(unsigned int cpu) > { > struct cpu_cacheinfo *this_cpu_ci; > - unsigned int levels, split_levels; > + unsigned int levels = 0, split_levels = 0; > int ret; > > if (acpi_disabled) { > -- > 2.25.1 >
diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c index 418a18acc8f9..f6573c335f4c 100644 --- a/drivers/base/cacheinfo.c +++ b/drivers/base/cacheinfo.c @@ -424,7 +424,7 @@ int allocate_cache_info(int cpu) int fetch_cache_info(unsigned int cpu) { struct cpu_cacheinfo *this_cpu_ci; - unsigned int levels, split_levels; + unsigned int levels = 0, split_levels = 0; int ret; if (acpi_disabled) {
Set potentially uninitialized variables to 0. This is particularly relevant when CONFIG_ACPI_PPTT is not set. Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/all/202301052307.JYt1GWaJ-lkp@intel.com/ Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/ Fixes: 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU") Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> --- drivers/base/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)